mirror of
https://github.com/wailsapp/wails.git
synced 2025-05-04 07:43:11 +08:00
d4096868e3
* Fix and optimize content type sniffer - Minimize copying and buffering - Ensure it sniffs the full 512-bytes prefix * Fix assorted warnings * Cleanup error formatting - Remove unnecessary formatting calls - Fix invalid format strings - Standardise logging calls * Fix and optimize index fallback method - Pass through non-404 responses correctly - Do not buffer original response * Test content sniffing and index fallback * Update changelog * Remove obsolete check * Add safety checks in sniffer
245 lines
5.6 KiB
Go
245 lines
5.6 KiB
Go
package assetserver
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
_ "unsafe"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
)
|
|
|
|
func TestContentSniffing(t *testing.T) {
|
|
longLead := strings.Repeat(" ", 512-6)
|
|
|
|
tests := map[string]struct {
|
|
Expect string
|
|
Status int
|
|
Header map[string][]string
|
|
Body []string
|
|
}{
|
|
"/simple": {
|
|
Expect: "text/html; charset=utf-8",
|
|
Body: []string{"<html><body>Hello!</body></html>"},
|
|
},
|
|
"/split": {
|
|
Expect: "text/html; charset=utf-8",
|
|
Body: []string{
|
|
"<html><body>Hello!",
|
|
"</body></html>",
|
|
},
|
|
},
|
|
"/lead/short/simple": {
|
|
Expect: "text/html; charset=utf-8",
|
|
Body: []string{
|
|
" " + "<html><body>Hello!</body></html>",
|
|
},
|
|
},
|
|
"/lead/short/split": {
|
|
Expect: "text/html; charset=utf-8",
|
|
Body: []string{
|
|
" ",
|
|
"<html><body>Hello!</body></html>",
|
|
},
|
|
},
|
|
"/lead/long/simple": {
|
|
Expect: "text/html; charset=utf-8",
|
|
Body: []string{
|
|
longLead + "<html><body>Hello!</body></html>",
|
|
},
|
|
},
|
|
"/lead/long/split": {
|
|
Expect: "text/html; charset=utf-8",
|
|
Body: []string{
|
|
longLead,
|
|
"<html><body>Hello!</body></html>",
|
|
},
|
|
},
|
|
"/lead/toolong/simple": {
|
|
Expect: "text/plain; charset=utf-8",
|
|
Body: []string{
|
|
"Hello" + longLead + "<html><body>Hello!</body></html>",
|
|
},
|
|
},
|
|
"/lead/toolong/split": {
|
|
Expect: "text/plain; charset=utf-8",
|
|
Body: []string{
|
|
"Hello" + longLead,
|
|
"<html><body>Hello!</body></html>",
|
|
},
|
|
},
|
|
"/header": {
|
|
Expect: "text/html; charset=utf-8",
|
|
Status: http.StatusForbidden,
|
|
Header: map[string][]string{
|
|
"X-Custom": {"CustomValue"},
|
|
},
|
|
Body: []string{"<html><body>Hello!</body></html>"},
|
|
},
|
|
"/custom": {
|
|
Expect: "text/plain;charset=utf-8",
|
|
Header: map[string][]string{
|
|
"Content-Type": {"text/plain;charset=utf-8"},
|
|
},
|
|
Body: []string{"<html><body>Hello!</body></html>"},
|
|
},
|
|
}
|
|
|
|
srv, err := NewAssetServer(&Options{
|
|
Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
test, ok := tests[r.URL.Path]
|
|
if !ok {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
return
|
|
}
|
|
|
|
for key, values := range test.Header {
|
|
for _, value := range values {
|
|
w.Header().Add(key, value)
|
|
}
|
|
}
|
|
|
|
if test.Status != 0 {
|
|
w.WriteHeader(test.Status)
|
|
}
|
|
|
|
for _, chunk := range test.Body {
|
|
w.Write([]byte(chunk))
|
|
}
|
|
}),
|
|
Logger: slog.Default(),
|
|
})
|
|
if err != nil {
|
|
t.Fatal("AssetServer initialisation failed: ", err)
|
|
}
|
|
|
|
for path, test := range tests {
|
|
t.Run(path[1:], func(t *testing.T) {
|
|
res := httptest.NewRecorder()
|
|
|
|
req, err := http.NewRequest(http.MethodGet, path, nil)
|
|
if err != nil {
|
|
t.Fatal("http.NewRequest failed: ", err)
|
|
}
|
|
|
|
srv.ServeHTTP(res, req)
|
|
|
|
expectedStatus := http.StatusOK
|
|
if test.Status != 0 {
|
|
expectedStatus = test.Status
|
|
}
|
|
if res.Code != expectedStatus {
|
|
t.Errorf("Status code mismatch: want %d, got %d", expectedStatus, res.Code)
|
|
}
|
|
|
|
if ct := res.Header().Get("Content-Type"); ct != test.Expect {
|
|
t.Errorf("Content type mismatch: want '%s', got '%s'", test.Expect, ct)
|
|
}
|
|
|
|
for key, values := range test.Header {
|
|
if diff := cmp.Diff(values, res.Header().Values(key)); diff != "" {
|
|
t.Errorf("Header '%s' mismatch (-want +got):\n%s", key, diff)
|
|
}
|
|
}
|
|
|
|
if diff := cmp.Diff(strings.Join(test.Body, ""), res.Body.String()); diff != "" {
|
|
t.Errorf("Response body mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestIndexFallback(t *testing.T) {
|
|
// Paths to try and whether a 404 should trigger a fallback.
|
|
paths := map[string]bool{
|
|
"": true,
|
|
"/": true,
|
|
"/index": false,
|
|
"/index.html": true,
|
|
"/other": false,
|
|
}
|
|
|
|
statuses := []int{
|
|
http.StatusOK,
|
|
http.StatusNotFound,
|
|
http.StatusForbidden,
|
|
}
|
|
|
|
header := map[string][]string{
|
|
"X-Custom": {"CustomValue"},
|
|
}
|
|
body := "<html><body>Hello!</body></html>"
|
|
|
|
srv, err := NewAssetServer(&Options{
|
|
Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
for key, values := range header {
|
|
for _, value := range values {
|
|
w.Header().Add(key, value)
|
|
}
|
|
}
|
|
|
|
status, err := strconv.Atoi(r.URL.Query().Get("status"))
|
|
if err == nil && status != 0 && status != http.StatusOK {
|
|
w.WriteHeader(status)
|
|
}
|
|
|
|
w.Write([]byte(body))
|
|
}),
|
|
Logger: slog.Default(),
|
|
})
|
|
if err != nil {
|
|
t.Fatal("AssetServer initialisation failed: ", err)
|
|
}
|
|
|
|
for path, fallback := range paths {
|
|
for _, status := range statuses {
|
|
key := "<empty path>"
|
|
if len(path) > 0 {
|
|
key = path[1:]
|
|
}
|
|
|
|
t.Run(fmt.Sprintf("%s/status=%d", key, status), func(t *testing.T) {
|
|
res := httptest.NewRecorder()
|
|
|
|
req, err := http.NewRequest(http.MethodGet, fmt.Sprintf("%s?status=%d", path, status), nil)
|
|
if err != nil {
|
|
t.Fatal("http.NewRequest failed: ", err)
|
|
}
|
|
|
|
srv.ServeHTTP(res, req)
|
|
|
|
fallbackTriggered := false
|
|
if status == http.StatusNotFound && fallback {
|
|
status = http.StatusOK
|
|
fallbackTriggered = true
|
|
}
|
|
|
|
if res.Code != status {
|
|
t.Errorf("Status code mismatch: want %d, got %d", status, res.Code)
|
|
}
|
|
|
|
if fallbackTriggered {
|
|
if cmp.Equal(body, res.Body.String()) {
|
|
t.Errorf("Fallback response has the same body as not found response")
|
|
}
|
|
return
|
|
} else {
|
|
for key, values := range header {
|
|
if diff := cmp.Diff(values, res.Header().Values(key)); diff != "" {
|
|
t.Errorf("Header '%s' mismatch (-want +got):\n%s", key, diff)
|
|
}
|
|
}
|
|
|
|
if diff := cmp.Diff(body, res.Body.String()); diff != "" {
|
|
t.Errorf("Response body mismatch (-want +got):\n%s", diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
}
|