From cfab21bc81b4511c9d10af4ee183d9e5338b995e Mon Sep 17 00:00:00 2001 From: Atterpac <89053530+atterpac@users.noreply.github.com> Date: Fri, 9 Aug 2024 14:26:37 -0700 Subject: [PATCH] fix syso icon generation (#3675) update changelog.md --- mkdocs-website/docs/en/changelog.md | 3 +++ v3/internal/commands/syso.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/mkdocs-website/docs/en/changelog.md b/mkdocs-website/docs/en/changelog.md index a7b41570b..10bb194bb 100644 --- a/mkdocs-website/docs/en/changelog.md +++ b/mkdocs-website/docs/en/changelog.md @@ -17,6 +17,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed +- [windows] Fixed syso icon file generation bug by [atterpac](https://github.com/atterpac) in [#3675](https://github.com/wailsapp/wails/pull/3675) + ## v3.0.0-alpha.6 - 2024-07-30 ### Fixed diff --git a/v3/internal/commands/syso.go b/v3/internal/commands/syso.go index 5bab7b6dc..b1736b749 100644 --- a/v3/internal/commands/syso.go +++ b/v3/internal/commands/syso.go @@ -44,7 +44,7 @@ func GenerateSyso(options *SysoOptions) (err error) { } defer func() { err2 := iconFile.Close() - if err == nil { + if err2 != nil { err = errors.Wrap(err, "error closing icon file: "+err2.Error()) } }()