github/wails
5
0
Fork 0
mirror of https://github.com/wailsapp/wails.git synced 2025-05-03 06:20:48 +08:00
Code Projects Activity

bugfix : fix error on building runnable .app on MacOS when 'name' and 'outputfilename' are different. (#3789)

Browse Source 
* mod : added OutputFilename field to assetData \n mod : modified resolveProjectData to export OutputFilename \n mod : modified CFBundleExecutable values to .OutputFilename in info.dev.plist, info.plist

* mod : update changelog.mdx

---------

Co-authored-by: nick-bae <nick.bae@ddkakaoenterprise.com>
This commit is contained in:
nick-bae 2024-09-29 12:06:27 +09:00 committed by GitHub
parent 429e94f4ce
commit bd2c1ea73f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
v2/pkg/buildassets/build/darwin/Info.dev.plist
View File

@ -6,7 +6,7 @@
<key>CFBundleName</key> <key>CFBundleName</key>
<string>{{.Info.ProductName}}</string> <string>{{.Info.ProductName}}</string>
<key>CFBundleExecutable</key> <key>CFBundleExecutable</key>
<string>{{.Name}}</string> <string>{{.OutputFilename}}</string>
<key>CFBundleIdentifier</key> <key>CFBundleIdentifier</key>
<string>com.wails.{{.Name}}</string> <string>com.wails.{{.Name}}</string>
<key>CFBundleVersion</key> <key>CFBundleVersion</key>

2
v2/pkg/buildassets/build/darwin/Info.plist
View File

@ -6,7 +6,7 @@
<key>CFBundleName</key> <key>CFBundleName</key>
<string>{{.Info.ProductName}}</string> <string>{{.Info.ProductName}}</string>
<key>CFBundleExecutable</key> <key>CFBundleExecutable</key>
<string>{{.Name}}</string> <string>{{.OutputFilename}}</string>
<key>CFBundleIdentifier</key> <key>CFBundleIdentifier</key>
<string>com.wails.{{.Name}}</string> <string>com.wails.{{.Name}}</string>
<key>CFBundleVersion</key> <key>CFBundleVersion</key>

2
v2/pkg/buildassets/buildassets.go
View File

@ -104,6 +104,7 @@ func ReadOriginalFileWithProjectDataAndSave(projectData *project.Project, file s
type assetData struct { type assetData struct {
Name string Name string
Info project.Info Info project.Info
OutputFilename string
} }
func resolveProjectData(content []byte, projectData *project.Project) ([]byte, error) { func resolveProjectData(content []byte, projectData *project.Project) ([]byte, error) {
@ -115,6 +116,7 @@ func resolveProjectData(content []byte, projectData *project.Project) ([]byte, e
data := &assetData{ data := &assetData{
Name: projectData.Name, Name: projectData.Name,
Info: projectData.Info, Info: projectData.Info,
OutputFilename: projectData.OutputFilename,
} }
var out bytes.Buffer var out bytes.Buffer

1
website/src/pages/changelog.mdx
View File

@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed dialogs in Windows when using Go 1.23 in [PR](https://github.com/wailsapp/wails/pull/3707) by [@leaanthony](https://github.com/leaanthony) - Fixed dialogs in Windows when using Go 1.23 in [PR](https://github.com/wailsapp/wails/pull/3707) by [@leaanthony](https://github.com/leaanthony)
- More syscall fixes for Go 1.23 support in [PR](https://github.com/wailsapp/wails/pull/3713) by [@leaanthony](https://github.com/leaanthony) - More syscall fixes for Go 1.23 support in [PR](https://github.com/wailsapp/wails/pull/3713) by [@leaanthony](https://github.com/leaanthony)
- Fixed drag and drop missing cursor icon [PR](https://github.com/wailsapp/wails/pull/3703) by [@mrf345](https://github.com/mrf345) - Fixed drag and drop missing cursor icon [PR](https://github.com/wailsapp/wails/pull/3703) by [@mrf345](https://github.com/mrf345)
- Fixed a build error on macOS that occurred when the `outputfilename` and `name` fields in wails.json were different. Fixed in [PR](https://github.com/wailsapp/wails/pull/3789) by [@nickisworking](https://github.com/nickisworking)
### Changed ### Changed
- Modified docs to reflect the correct password syntax for the `gon-sign.json` file [PR](https://github.com/wailsapp/wails/pull/3620) by [@ignasbernotas](github.com/ignasbernotas) - Modified docs to reflect the correct password syntax for the `gon-sign.json` file [PR](https://github.com/wailsapp/wails/pull/3620) by [@ignasbernotas](github.com/ignasbernotas)