github/wails
5
0
Fork 0
mirror of https://github.com/wailsapp/wails.git synced 2025-05-03 19:33:40 +08:00
Code Projects Activity

remove "'" around ldflags

Browse Source 
The single quote is needed for running the command in the shell directly.
When run inside the Go command 'os/exec' it is not removed and is
preventing the flags from being processed correctly inside the Docker image.
This commit is contained in:
Travis McLane 2020-04-04 07:55:57 -05:00 committed by Lea Anthony
parent 76edc7976e
commit 8405ce37f9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/helpers.go
View File

@ -149,7 +149,7 @@ func BuildApplication(binaryName string, forceRebuild bool, buildMode string, pa
}() }()
// Setup ld flags // Setup ld flags
ldflags := "'-w -s " ldflags := "-w -s "
if buildMode == BuildModeDebug { if buildMode == BuildModeDebug {
ldflags = "" ldflags = ""
} }
@ -170,7 +170,6 @@ func BuildApplication(binaryName string, forceRebuild bool, buildMode string, pa
filename := filepath.Join(cwd, projectOptions.FrontEnd.Dir, projectOptions.typescriptDefsFilename) filename := filepath.Join(cwd, projectOptions.FrontEnd.Dir, projectOptions.typescriptDefsFilename)
ldflags += " -X github.com/wailsapp/wails/lib/binding.typescriptDefinitionFilename=" + filename ldflags += " -X github.com/wailsapp/wails/lib/binding.typescriptDefinitionFilename=" + filename
} }
ldflags += "'"
buildCommand := slicer.String() buildCommand := slicer.String()
if projectOptions.CrossCompile { if projectOptions.CrossCompile {