From 8405ce37f982d258a31dc939aa5032494d6231c9 Mon Sep 17 00:00:00 2001 From: Travis McLane Date: Sat, 4 Apr 2020 07:55:57 -0500 Subject: [PATCH] remove "'" around ldflags The single quote is needed for running the command in the shell directly. When run inside the Go command 'os/exec' it is not removed and is preventing the flags from being processed correctly inside the Docker image. --- cmd/helpers.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/helpers.go b/cmd/helpers.go index 9b0931b69..851f4200f 100644 --- a/cmd/helpers.go +++ b/cmd/helpers.go @@ -149,7 +149,7 @@ func BuildApplication(binaryName string, forceRebuild bool, buildMode string, pa }() // Setup ld flags - ldflags := "'-w -s " + ldflags := "-w -s " if buildMode == BuildModeDebug { ldflags = "" } @@ -170,7 +170,6 @@ func BuildApplication(binaryName string, forceRebuild bool, buildMode string, pa filename := filepath.Join(cwd, projectOptions.FrontEnd.Dir, projectOptions.typescriptDefsFilename) ldflags += " -X github.com/wailsapp/wails/lib/binding.typescriptDefinitionFilename=" + filename } - ldflags += "'" buildCommand := slicer.String() if projectOptions.CrossCompile {