From 5ae621ceaa4765a48dfd4fb14725ab4ba6efe9ed Mon Sep 17 00:00:00 2001 From: Lea Anthony Date: Mon, 22 Feb 2021 19:33:18 +1100 Subject: [PATCH] Start signal handler a little later --- v2/internal/app/desktop.go | 16 ++++++++-------- v2/internal/app/dev.go | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/v2/internal/app/desktop.go b/v2/internal/app/desktop.go index 0e76efec5..44ca8de1d 100644 --- a/v2/internal/app/desktop.go +++ b/v2/internal/app/desktop.go @@ -117,14 +117,6 @@ func (a *App) Run() error { parentContext := context.WithValue(context.Background(), "waitgroup", &subsystemWaitGroup) ctx, cancel := context.WithCancel(parentContext) - // Setup signal handler - signalsubsystem, err := signal.NewManager(ctx, cancel, a.servicebus, a.logger) - if err != nil { - return err - } - a.signal = signalsubsystem - a.signal.Start() - // Start the service bus a.servicebus.Debug() err = a.servicebus.Start() @@ -207,6 +199,14 @@ func (a *App) Run() error { return err } + // Setup signal handler + signalsubsystem, err := signal.NewManager(ctx, cancel, a.servicebus, a.logger) + if err != nil { + return err + } + a.signal = signalsubsystem + a.signal.Start() + err = a.window.Run(dispatcher, bindingDump, a.debug) a.logger.Trace("Ffenestri.Run() exited") if err != nil { diff --git a/v2/internal/app/dev.go b/v2/internal/app/dev.go index 48aaf32ec..b92fb441e 100644 --- a/v2/internal/app/dev.go +++ b/v2/internal/app/dev.go @@ -118,14 +118,6 @@ func (a *App) Run() error { parentContext := context.WithValue(context.Background(), "waitgroup", &subsystemWaitGroup) ctx, cancel := context.WithCancel(parentContext) - // Setup signal handler - signalsubsystem, err := signal.NewManager(ctx, cancel, a.servicebus, a.logger) - if err != nil { - return err - } - a.signal = signalsubsystem - a.signal.Start() - // Start the service bus a.servicebus.Debug() err = a.servicebus.Start() @@ -211,6 +203,14 @@ func (a *App) Run() error { // Generate backend.js a.bindings.GenerateBackendJS() + // Setup signal handler + signalsubsystem, err := signal.NewManager(ctx, cancel, a.servicebus, a.logger) + if err != nil { + return err + } + a.signal = signalsubsystem + a.signal.Start() + err = a.bridge.Run(dispatcher, a.menuManager, bindingDump, a.debug) a.logger.Trace("Bridge.Run() exited") if err != nil {