github/wails
5
0
Fork 0
mirror of https://github.com/wailsapp/wails.git synced 2025-05-03 06:51:26 +08:00
Code Projects Activity

[dev] Remove redundant steps that are also executed during build.Build (#2196)

Browse Source 
* Remove redundant generation of bindings
* Remove redundant CreateEmbedDirectories
This commit is contained in:
stffabi 2022-12-13 13:44:00 +01:00 committed by GitHub
parent 4aab1e6b93
commit 55ca6c0bf3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
v2/cmd/wails/internal/dev/dev.go
View File

@ -4,10 +4,6 @@ import (
"context" "context"
"errors" "errors"
"fmt" "fmt"
"github.com/samber/lo"
"github.com/wailsapp/wails/v2/cmd/wails/flags"
"github.com/wailsapp/wails/v2/cmd/wails/internal/gomod"
"github.com/wailsapp/wails/v2/cmd/wails/internal/logutils"
"io" "io"
"net/http" "net/http"
"net/url" "net/url"
@ -22,7 +18,11 @@ import (
"syscall" "syscall"
"time" "time"
"github.com/wailsapp/wails/v2/pkg/commands/bindings" "github.com/samber/lo"
"github.com/wailsapp/wails/v2/cmd/wails/flags"
"github.com/wailsapp/wails/v2/cmd/wails/internal/gomod"
"github.com/wailsapp/wails/v2/cmd/wails/internal/logutils"
"github.com/wailsapp/wails/v2/pkg/commands/buildtags" "github.com/wailsapp/wails/v2/pkg/commands/buildtags"
"github.com/google/shlex" "github.com/google/shlex"
@ -96,30 +96,8 @@ func Application(f *flags.Dev, logger *clilogger.CLILogger) error {
buildOptions.UserTags = userTags buildOptions.UserTags = userTags
err = build.CreateEmbedDirectories(cwd, buildOptions)
if err != nil {
return err
}
projectConfig := f.ProjectConfig() projectConfig := f.ProjectConfig()
if !buildOptions.SkipBindings {
if f.Verbosity == build.VERBOSE {
logutils.LogGreen("Generating Bindings...")
}
stdout, err := bindings.GenerateBindings(bindings.Options{
Tags: buildOptions.UserTags,
TsPrefix: projectConfig.Bindings.TsGeneration.Prefix,
TsSuffix: projectConfig.Bindings.TsGeneration.Suffix,
})
if err != nil {
return err
}
if f.Verbosity == build.VERBOSE {
logutils.LogGreen(stdout)
}
}
// Setup signal handler // Setup signal handler
quitChannel := make(chan os.Signal, 1) quitChannel := make(chan os.Signal, 1)
signal.Notify(quitChannel, os.Interrupt, os.Kill, syscall.SIGTERM) signal.Notify(quitChannel, os.Interrupt, os.Kill, syscall.SIGTERM)