From 55ca6c0bf33605b977ea3ded40b5ceef01e2738e Mon Sep 17 00:00:00 2001 From: stffabi Date: Tue, 13 Dec 2022 13:44:00 +0100 Subject: [PATCH] [dev] Remove redundant steps that are also executed during build.Build (#2196) * Remove redundant generation of bindings * Remove redundant CreateEmbedDirectories --- v2/cmd/wails/internal/dev/dev.go | 32 +++++--------------------------- 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/v2/cmd/wails/internal/dev/dev.go b/v2/cmd/wails/internal/dev/dev.go index 2cd11510b..a17ed5977 100644 --- a/v2/cmd/wails/internal/dev/dev.go +++ b/v2/cmd/wails/internal/dev/dev.go @@ -4,10 +4,6 @@ import ( "context" "errors" "fmt" - "github.com/samber/lo" - "github.com/wailsapp/wails/v2/cmd/wails/flags" - "github.com/wailsapp/wails/v2/cmd/wails/internal/gomod" - "github.com/wailsapp/wails/v2/cmd/wails/internal/logutils" "io" "net/http" "net/url" @@ -22,7 +18,11 @@ import ( "syscall" "time" - "github.com/wailsapp/wails/v2/pkg/commands/bindings" + "github.com/samber/lo" + "github.com/wailsapp/wails/v2/cmd/wails/flags" + "github.com/wailsapp/wails/v2/cmd/wails/internal/gomod" + "github.com/wailsapp/wails/v2/cmd/wails/internal/logutils" + "github.com/wailsapp/wails/v2/pkg/commands/buildtags" "github.com/google/shlex" @@ -96,30 +96,8 @@ func Application(f *flags.Dev, logger *clilogger.CLILogger) error { buildOptions.UserTags = userTags - err = build.CreateEmbedDirectories(cwd, buildOptions) - if err != nil { - return err - } - projectConfig := f.ProjectConfig() - if !buildOptions.SkipBindings { - if f.Verbosity == build.VERBOSE { - logutils.LogGreen("Generating Bindings...") - } - stdout, err := bindings.GenerateBindings(bindings.Options{ - Tags: buildOptions.UserTags, - TsPrefix: projectConfig.Bindings.TsGeneration.Prefix, - TsSuffix: projectConfig.Bindings.TsGeneration.Suffix, - }) - if err != nil { - return err - } - if f.Verbosity == build.VERBOSE { - logutils.LogGreen(stdout) - } - } - // Setup signal handler quitChannel := make(chan os.Signal, 1) signal.Notify(quitChannel, os.Interrupt, os.Kill, syscall.SIGTERM)