From 3a72dd6a0deff95eac2c49b52a7cf52c78f14a56 Mon Sep 17 00:00:00 2001 From: Lea Anthony Date: Sat, 26 Apr 2025 12:40:35 +1000 Subject: [PATCH] Fix for #4235 --- v3/BETA_READINESS.md | 78 +++++++++++++-------------- v3/pkg/application/dialogs_windows.go | 5 +- 2 files changed, 43 insertions(+), 40 deletions(-) diff --git a/v3/BETA_READINESS.md b/v3/BETA_READINESS.md index 5822db5f9..486a01dc9 100644 --- a/v3/BETA_READINESS.md +++ b/v3/BETA_READINESS.md @@ -4,45 +4,45 @@ This document is for tracking the status of the v3-alpha branch in readiness for ## Examples -| Example | Linux | Windows | macOS | -|--------------------|-------|--------------------------------------------------|-------| -| badge | | ✅ | | -| binding | | ✅ | ✅ | -| cancel-async | | ✅ | ✅ | -| cancel-chaining | | ✅ | ✅ | -| clipboard | | ✅ | ✅ | -| context-menus | | ✅ | 🚫 panic | -| dialogs | | ⚠️ custom icon not working | ⚠️ | -| dialogs-basic | | ⚠️ cancel crashes the app | ✅ | -| drag-n-drop | | ✅ | ✅ | -| environment | | ✅ | ✅ | -| events | | ✅ | ✅ | -| file-association | | ✅ | ✅ | -| frameless | | ✅ | ⚠️ minimise for 3 not working | -| gin-example | | ✅ | ✅ | -| gin-routing | | ✅ | ⚠️ cant see difference from gin-example (copy/paste?) | -| gin-service | | ✅ | ⚠️ half buttons does nothing? ( getuserbyid ) | -| html-dnd-api | | 🚫 | ✅ | -| ignore-mouse | | ✅ | ✅ | -| keybindings | | ✅ | ✅ | -| menu | | ⚠️ Hide/Unhide issue | ✅ | -| notifications | | ✅ | ⚠️ nothing happens on button click | -| panic-handling | | ✅ | ✅ | -| plain | | ✅ | ✅ | -| raw-message | | ✅ | ✅ | -| screen | | ✅ | ⚠️ slider bubble drags window | -| services | | ⚠️ KV needs refreshing after save | ⚠️ update kv doesnt updates view on update value | -| show-macos-toolbar | | ➖ | ✅ | -| single-instance | | ✅ | ✅ | -| systray-basic | | ✅ | ✅ | -| systray-custom | | ✅ | ✅ | -| systray-menu | | ⚠️ Check systray.Hide/Show | ✅ | -| video | | ✅ | ✅ | -| window | | ⚠️ SetPos 0,0 is going to 5,0. GetPos is correct | ✅ | -| window-api | | ✅ | ✅ | -| window-call | | ✅ | ✅ | -| window-menubar | | ✅ | ⚠️ not sure what should happen in osx | -| wml | | ✅ | ✅ | +| Example | Linux | Windows | macOS | +|--------------------|-------|--------------------------------------------------|-------------------------------------------------------| +| badge | | ✅ | | +| binding | | ✅ | ✅ | +| cancel-async | | ✅ | ✅ | +| cancel-chaining | | ✅ | ✅ | +| clipboard | | ✅ | ✅ | +| context-menus | | ✅ | 🚫 panic | +| dialogs | | ⚠️ custom icon not working | ⚠️ | +| dialogs-basic | | ⚠️ cancel crashes the app | ✅ | +| drag-n-drop | | ✅ | ✅ | +| environment | | ✅ | ✅ | +| events | | ✅ | ✅ | +| file-association | | ✅ | ✅ | +| frameless | | ✅ | ⚠️ minimise for 3 not working | +| gin-example | | ✅ | ✅ | +| gin-routing | | ✅ | ⚠️ cant see difference from gin-example (copy/paste?) | +| gin-service | | ✅ | ⚠️ half buttons does nothing? ( getuserbyid ) | +| html-dnd-api | | 🚫 | ✅ | +| ignore-mouse | | ✅ | ✅ | +| keybindings | | ✅ | ✅ | +| menu | | ⚠️ Hide/Unhide issue | ✅ | +| notifications | | ✅ | ⚠️ nothing happens on button click | +| panic-handling | | ✅ | ✅ | +| plain | | ✅ | ✅ | +| raw-message | | ✅ | ✅ | +| screen | | ✅ | ⚠️ slider bubble drags window | +| services | | ⚠️ KV needs refreshing after save | ⚠️ update kv doesnt updates view on update value | +| show-macos-toolbar | | ➖ | ✅ | +| single-instance | | ✅ | ✅ | +| systray-basic | | ✅ | ✅ | +| systray-custom | | ✅ | ✅ | +| systray-menu | | ⚠️ Check systray.Hide/Show | ✅ | +| video | | ✅ | ✅ | +| window | | ⚠️ SetPos 0,0 is going to 5,0. GetPos is correct | ✅ | +| window-api | | ✅ | ✅ | +| window-call | | ✅ | ✅ | +| window-menubar | | ✅ | ⚠️ not sure what should happen in osx | +| wml | | ✅ | ✅ | ## Open Bugs diff --git a/v3/pkg/application/dialogs_windows.go b/v3/pkg/application/dialogs_windows.go index ef5b625fc..e4e378988 100644 --- a/v3/pkg/application/dialogs_windows.go +++ b/v3/pkg/application/dialogs_windows.go @@ -198,7 +198,10 @@ func (m *windowSaveFileDialog) show() (chan string, error) { }, false) go func() { defer handlePanic() - files <- result.(string) + filename, ok := result.(string) + if ok { + files <- filename + } close(files) }() return files, err