github/wails
5
0
Fork 0
mirror of https://github.com/wailsapp/wails.git synced 2025-05-03 01:43:15 +08:00
Code Projects Activity

The outputFile was only being set for darwin universal builds. I move… (#2358)

Browse Source 
* The outputFile was only being set for darwin universal builds. I moved the
variable assignment to a location where it will take place for all builds.

The ProjectData entries are used in generating the .app plist file, so
setting them here ensures that the app will run with the custom binary name.

* Increases the reach of the output flag.

* Updates the changelog with a record of this fix.
This commit is contained in:
Gwyn 2023-02-24 12:13:27 -07:00 committed by GitHub
parent c20ccfb9a6
commit 017ce1e33e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
v2/pkg/commands/build/build.go
View File

@ -262,9 +262,12 @@ func execBuildApplication(builder Builder, options *Options) (string, error) {
// Compile the application // Compile the application
printBulletPoint("Compiling application: ") printBulletPoint("Compiling application: ")
outputFile := builder.OutputFilename(options)
options.ProjectData.OutputFilename = outputFile
options.ProjectData.Name = outputFile
options.ProjectData.Info.ProductName = outputFile
if options.Platform == "darwin" && options.Arch == "universal" { if options.Platform == "darwin" && options.Arch == "universal" {
outputFile := builder.OutputFilename(options)
amd64Filename := outputFile + "-amd64" amd64Filename := outputFile + "-amd64"
arm64Filename := outputFile + "-arm64" arm64Filename := outputFile + "-arm64"

1
website/src/pages/changelog.mdx
View File

@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed the sometimes lagging drag experience with `--wails-draggable` on Windows. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/2302) - Fixed the sometimes lagging drag experience with `--wails-draggable` on Windows. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/2302)
- Fixed applying the default arch to platform flag in wails cli. If only a `GOOS` has been supplied as platform flag e.g. `wails build --platform windows` the current architecture wasn't applied and the build failed. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/2309) - Fixed applying the default arch to platform flag in wails cli. If only a `GOOS` has been supplied as platform flag e.g. `wails build --platform windows` the current architecture wasn't applied and the build failed. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/2309)
- Fixed a segfault on opening the inspector on older macOS versions. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/2397) - Fixed a segfault on opening the inspector on older macOS versions. Fixed by @stffabi in [PR](https://github.com/wailsapp/wails/pull/2397)
- Fixed the macos single architecture builds not respecting an output file name specified with the '-o' flag. Fixed by @gwynforthewyn in [PR](https://github.com/wailsapp/wails/pull/2358)
## v2.3.0 - 2022-12-29 ## v2.3.0 - 2022-12-29