github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-17 09:20:43 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-2739: Sqoop2: Use resource name instead of resource id in authorization engine

Browse Source 
(Colin Ma via Jarek Jarcec Cecho)
This commit is contained in:
Jarek Jarcec Cecho 2015-12-18 08:14:17 +01:00
parent c5962f8e15
commit f4909a5634
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java
View File

@ -33,18 +33,14 @@
public class AuthorizationEngine { public class AuthorizationEngine {
private static String getResourceName(MResource.TYPE resourceType, long resourceId) { private static String getResourceName(Object resource) {
Repository repository = RepositoryManager.getInstance().getRepository(); if (resource instanceof MConnector) {
return ((MConnector)resource).getUniqueName();
switch (resourceType) { } else if (resource instanceof MLink) {
case CONNECTOR: return ((MLink)resource).getName();
return repository.findConnector(resourceId).getUniqueName(); } else if (resource instanceof MJob) {
case LINK: return ((MJob)resource).getName();
return repository.findLink(resourceId).getName();
case JOB:
return repository.findJob(resourceId).getName();
} }
return null; return null;
} }
@ -56,7 +52,7 @@ public static <T extends MPersistableEntity> List<T> filterResource(final String
@Override @Override
public boolean apply(T input) { public boolean apply(T input) {
try { try {
String name = getResourceName(type, input.getPersistenceId()); String name = getResourceName(input);
checkPrivilege(doUserName, getPrivilege(type, name, MPrivilege.ACTION.READ)); checkPrivilege(doUserName, getPrivilege(type, name, MPrivilege.ACTION.READ));
// add valid resource // add valid resource
return true; return true;