github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-13 07:21:08 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-1669: Sqoop2: JDBC connector does not understand iso8610 representation using " " as separator

Browse Source 
(Qian Xu via Jarek Jarcec Cecho)
This commit is contained in:
Jarek Jarcec Cecho 2014-11-05 06:35:37 -08:00
parent 3c111205c0
commit e4455d193b
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
View File

@ -220,7 +220,11 @@ public Object[] getObjectData() {
out[i] = LocalDate.parse(fields[i]);
break;
case DATE_TIME:
out[i] = LocalDateTime.parse(fields[i]);
// A datetime string with a space as date-time separator will not be
// parsed expectedly. The expected separator is "T". See also:
// https://github.com/JodaOrg/joda-time/issues/11
String iso8601 = fields[i].replace(" ", "T");
out[i] = LocalDateTime.parse(iso8601);
break;
case BIT:
out[i] = Boolean.valueOf(fields[i].equals("1")

21
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
View File

@ -251,6 +251,27 @@ public void testDateTime() {
}
}
/**
* In ISO8601 "T" is used as date-time separator. Unfortunately in the real
* world, database (confirmed with mysql and postgres) might return a datatime
* string with a space as separator. The test case intends to check, whether
* such datatime string can be handled expectedly.
*/
@Test
public void testDateTimeISO8601Alternative() {
Schema schema = new Schema("test");
schema.addColumn(new DateTime("1"));
data.setSchema(schema);
for (String dateTime : new String[]{
"2014-10-01 12:00:00",
"2014-10-01 12:00:00.000"
}) {
data.setTextData(dateTime);
assertEquals("2014-10-01T12:00:00.000", data.getObjectData()[0].toString());
}
}
@Test
public void testBit() {
Schema schema = new Schema("test");