From dd3bfa3981e4496a450f59fe8e2dfef903ca65a8 Mon Sep 17 00:00:00 2001 From: Jarek Jarcec Cecho Date: Thu, 2 May 2013 22:37:02 -0700 Subject: [PATCH] SQOOP-1012: Sqoop2: Generic JDBC Connector should have one static instance of validator (Vasanth kumar RJ via Jarek Jarcec Cecho) --- .../apache/sqoop/connector/jdbc/GenericJdbcConnector.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java b/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java index 11c10def..e0da80f7 100644 --- a/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java +++ b/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java @@ -33,6 +33,8 @@ public class GenericJdbcConnector extends SqoopConnector { + private static GenericJdbcValidator genericJdbcValidator = new GenericJdbcValidator(); + private static final Importer IMPORTER = new Importer( GenericJdbcImportInitializer.class, GenericJdbcImportPartitioner.class, @@ -91,8 +93,7 @@ public Exporter getExporter() { @Override public Validator getValidator() { - // TODO(jarcec): Cache this object eventually - return new GenericJdbcValidator(); + return genericJdbcValidator; } @Override