github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-03 22:20:52 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-1161: Generated Delimiter Set Field Should be Static

Browse Source 
(Nick White via Jarek Jarcec Cecho)
This commit is contained in:
Jarek Jarcec Cecho 2013-08-15 08:31:38 -07:00
parent a9089430e4
commit db89861c0c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/java/org/apache/sqoop/orm/ClassWriter.java
View File

@ -808,7 +808,7 @@ private void generateToString(Map<String, Integer> columnTypes,
String [] colNames, StringBuilder sb) {
// Save the delimiters to the class.
sb.append(" private final DelimiterSet __outputDelimiters = ");
sb.append(" private static final DelimiterSet __outputDelimiters = ");
sb.append(options.getOutputDelimiters().formatConstructor() + ";\n");
// The default toString() method itself follows. This just calls
@ -972,7 +972,7 @@ private void parseColumn(String colName, int colType, StringBuilder sb) {
sb.append(" String[] strByteVal = __cur_str.trim().split(\" \");\n");
sb.append(" byte [] byteVal = new byte[strByteVal.length];\n");
sb.append(" for (int i = 0; i < byteVal.length; ++i) {\n");
sb.append(" byteVal[i] = (byte)Integer.parseInt(strByteVal[i], 16);\n");
sb.append(" byteVal[i] = (byte)Integer.parseInt(strByteVal[i], 16);\n");
sb.append(" }\n");
sb.append(" this." + colName + " = new BytesWritable(byteVal);\n");
} else {
@ -995,7 +995,7 @@ private void generateParser(Map<String, Integer> columnTypes,
// records. Note that these can differ from the delims to use as output
// via toString(), if the user wants to use this class to convert one
// format to another.
sb.append(" private final DelimiterSet __inputDelimiters = ");
sb.append(" private static final DelimiterSet __inputDelimiters = ");
sb.append(options.getInputDelimiters().formatConstructor() + ";\n");
// The parser object which will do the heavy lifting for field splitting.