From c78b75a645fa77e55809da57fedee3b0dea2fe60 Mon Sep 17 00:00:00 2001
From: Jarek Jarcec Cecho <jarcec@apache.org>
Date: Mon, 6 Oct 2014 06:46:46 -0700
Subject: [PATCH] SQOOP-1562: Sqoop2: BIT handling in CSV IDF

(Abraham Elmahrek via Jarek Jarcec Cecho)
---
 .../idf/CSVIntermediateDataFormat.java        |  3 ++-
 .../idf/TestCSVIntermediateDataFormat.java    | 25 ++++++++++++++++++-
 2 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
index 3c3543c5..7eb1d8d0 100644
--- a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
+++ b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
@@ -223,7 +223,8 @@ public Object[] getObjectData() {
           out[i] = LocalDateTime.parse(fields[i]);
           break;
         case BIT:
-          out[i] = fields[i];
+          out[i] = Boolean.valueOf(fields[i].equals("1")
+              || fields[i].toLowerCase().equals("true"));
           break;
         default:
           throw new SqoopException(IntermediateDataFormatError.INTERMEDIATE_DATA_FORMAT_0004, "Column type from schema was not recognized for " + colType);
diff --git a/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java b/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
index 3159883d..74f2e073 100644
--- a/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
+++ b/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
@@ -19,6 +19,7 @@
 package org.apache.sqoop.connector.idf;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
@@ -28,6 +29,7 @@
 import org.apache.sqoop.common.SqoopException;
 import org.apache.sqoop.schema.Schema;
 import org.apache.sqoop.schema.type.Binary;
+import org.apache.sqoop.schema.type.Bit;
 import org.apache.sqoop.schema.type.Date;
 import org.apache.sqoop.schema.type.DateTime;
 import org.apache.sqoop.schema.type.FixedPoint;
@@ -195,7 +197,7 @@ public void testStringFullRangeOfCharacters() {
 
     Object[] in = {strData};
     Object[] inCopy = new Object[1];
-    System.arraycopy(in,0,inCopy,0,in.length);
+    System.arraycopy(in, 0, inCopy, 0, in.length);
 
     // Modifies the input array, so we use the copy to confirm
     data.setObjectData(in);
@@ -249,6 +251,27 @@ public void testDateTime() {
     }
   }
 
+  @Test
+  public void testBit() {
+    Schema schema = new Schema("test");
+    schema.addColumn(new Bit("1"));
+    data.setSchema(schema);
+
+    for (String trueBit : new String[]{
+        "true", "TRUE", "1"
+    }) {
+      data.setTextData(trueBit);
+      assertTrue((Boolean) data.getObjectData()[0]);
+    }
+
+    for (String falseBit : new String[]{
+        "false", "FALSE", "0"
+    }) {
+      data.setTextData(falseBit);
+      assertFalse((Boolean) data.getObjectData()[0]);
+    }
+  }
+
   @Test(expected=SqoopException.class)
   public void testEmptySchema() {
     String testData = "10,34,'54','random data'," + getByteFieldString(new byte[] { (byte) -112, (byte) 54})