github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-19 02:10:54 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-686 Empty job name will result in NPE during job submission

Browse Source 
(Jarek Jarcec Cecho)
This commit is contained in:
Bilung Lee 2012-11-09 09:59:47 -08:00
parent fdfc18c831
commit c47a15368e
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
View File

@ -312,6 +312,7 @@ public static MSubmission submit(long jobId) {
connectorConnection, connectorJob,
frameworkConnection, frameworkJob);
request.setJobName(job.getName());
request.setJobId(job.getPersistenceId());
// Let's register all important jars
// sqoop-common

13
core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java
View File

@ -43,6 +43,11 @@ public class SubmissionRequest {
*/
String jobName;
/**
* Associated job (from metadata perspective) id
*/
long jobId;
/**
* Connector instance associated with this submission request
*/
@ -111,6 +116,14 @@ public void setJobName(String jobName) {
this.jobName = jobName;
}
public long getJobId() {
return jobId;
}
public void setJobId(long jobId) {
this.jobId = jobId;
}
public SqoopConnector getConnector() {
return connector;
}

7
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
View File

@ -185,7 +185,12 @@ public boolean submit(SubmissionRequest generalRequest) {
try {
Job job = Job.getInstance(configuration);
job.setJobName(request.getJobName());
if(request.getJobName() != null) {
job.setJobName("Sqoop: " + request.getJobName());
} else {
job.setJobName("Sqoop job with id: " + request.getJobId());
}
job.setInputFormatClass(request.getInputFormatClass());