github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-09 03:59:46 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-2239: Sqoop2: Remove Repository.updateSubmission() call from Mapreduce submission engine

Browse Source 
(Jarek Jarcec Cecho via Abraham Elmahrek)
This commit is contained in:
Abraham Elmahrek 2015-03-25 15:10:30 -07:00
parent 029e8ff56a
commit be74759e78
2 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
core/src/main/java/org/apache/sqoop/driver/JobManager.java
View File

@ -557,7 +557,7 @@ public MSubmission stop(long jobId, HttpEventContext ctx) {
mSubmission.setLastUpdateUser(ctx.getUsername());
// Fetch new information to verify that the stop command has actually worked
submissionEngine.update(mSubmission);
updateSubmission(mSubmission);
// Return updated structure
return mSubmission;
@ -570,14 +570,25 @@ public MSubmission status(long jobId) {
if (mSubmission == null) {
return new MSubmission(jobId, new Date(), SubmissionStatus.NEVER_EXECUTED);
}
// If the submission isin running state, let's update it
// If the submission is in running state, let's update it
if (mSubmission.getStatus().isRunning()) {
submissionEngine.update(mSubmission);
updateSubmission(mSubmission);
}
return mSubmission;
}
/**
* Get latest status of the submission from execution engine and
* persist that in the repository.
*
* @param submission Submission to update
*/
public void updateSubmission(MSubmission submission) {
submissionEngine.update(submission);
RepositoryManager.getInstance().getRepository().updateSubmission(submission);
}
@Override
public synchronized void configurationChanged() {
LOG.info("Begin submission engine manager reconfiguring");
@ -676,7 +687,7 @@ public void run() {
.findUnfinishedSubmissions();
for (MSubmission submission : unfinishedSubmissions) {
submissionEngine.update(submission);
updateSubmission(submission);
}
Thread.sleep(updateSleep);

2
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
View File

@ -475,8 +475,6 @@ public void update(MSubmission submission) {
submission.setProgress(progress);
submission.setCounters(counters);
submission.setLastUpdateDate(new Date());
RepositoryManager.getInstance().getRepository().updateSubmission(submission);
} catch (IOException e) {
throw new SqoopException(MapreduceSubmissionError.MAPREDUCE_0003, e);
}