From b4d59da6716b44fce1e5161c8aef6dc32b585c6d Mon Sep 17 00:00:00 2001 From: Andrew Bayer Date: Fri, 22 Jul 2011 20:03:46 +0000 Subject: [PATCH] Fix dead store in SqoopOptions.setTmpDir(). From: Aaron Kimball git-svn-id: https://svn.apache.org/repos/asf/incubator/sqoop/trunk@1149895 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/hadoop/sqoop/SqoopOptions.java | 2 +- src/test/org/apache/hadoop/sqoop/TestSqoopOptions.java | 4 ++-- src/test/org/apache/hadoop/sqoop/hive/TestHiveImport.java | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/java/org/apache/hadoop/sqoop/SqoopOptions.java b/src/java/org/apache/hadoop/sqoop/SqoopOptions.java index 8bf25c00..4441a9f7 100644 --- a/src/java/org/apache/hadoop/sqoop/SqoopOptions.java +++ b/src/java/org/apache/hadoop/sqoop/SqoopOptions.java @@ -367,7 +367,7 @@ public String getTmpDir() { } public void setTmpDir(String tmp) { - this.tmpDir = tmpDir; + this.tmpDir = tmp; } public String getConnectString() { diff --git a/src/test/org/apache/hadoop/sqoop/TestSqoopOptions.java b/src/test/org/apache/hadoop/sqoop/TestSqoopOptions.java index 3ebb43cc..28af472a 100644 --- a/src/test/org/apache/hadoop/sqoop/TestSqoopOptions.java +++ b/src/test/org/apache/hadoop/sqoop/TestSqoopOptions.java @@ -202,7 +202,7 @@ public void testBadNumMappers1() throws Exception { }; try { - SqoopOptions opts = parse(args); + parse(args); fail("Expected InvalidOptionsException"); } catch (SqoopOptions.InvalidOptionsException ioe) { // expected. @@ -216,7 +216,7 @@ public void testBadNumMappers2() throws Exception { }; try { - SqoopOptions opts = parse(args); + parse(args); fail("Expected InvalidOptionsException"); } catch (SqoopOptions.InvalidOptionsException ioe) { // expected. diff --git a/src/test/org/apache/hadoop/sqoop/hive/TestHiveImport.java b/src/test/org/apache/hadoop/sqoop/hive/TestHiveImport.java index 58c348d9..ecc64d0d 100644 --- a/src/test/org/apache/hadoop/sqoop/hive/TestHiveImport.java +++ b/src/test/org/apache/hadoop/sqoop/hive/TestHiveImport.java @@ -173,7 +173,6 @@ public void testGenerateOnly() throws IOException { setNumCols(1); // Figure out where our target generated .q file is going to be. - String [] emptyArgs = new String[0]; SqoopOptions options = getSqoopOptions(getArgv(false, null), new ImportTool()); Path ddlFile = new Path(new Path(options.getCodeOutputDir()),