From b3ebfdda6166d3402bd4a7e45b74b5b8f2a6cddf Mon Sep 17 00:00:00 2001
From: Kate Ting <kathleen@apache.org>
Date: Mon, 13 May 2013 00:31:33 -0400
Subject: [PATCH] SQOOP-1044: Sqoop2: Improve logging in metadata upgrade
 methods

(Jarek Jarcec Cecho via Kate Ting)
---
 .../java/org/apache/sqoop/repository/Repository.java   | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/org/apache/sqoop/repository/Repository.java b/core/src/main/java/org/apache/sqoop/repository/Repository.java
index 3e34ccbf..21dd759e 100644
--- a/core/src/main/java/org/apache/sqoop/repository/Repository.java
+++ b/core/src/main/java/org/apache/sqoop/repository/Repository.java
@@ -17,6 +17,7 @@
  */
 package org.apache.sqoop.repository;
 
+import org.apache.log4j.Logger;
 import org.apache.sqoop.common.SqoopException;
 import org.apache.sqoop.connector.ConnectorManager;
 import org.apache.sqoop.connector.spi.MetadataUpgrader;
@@ -49,6 +50,8 @@
  */
 public abstract class Repository {
 
+  private static final Logger LOG = Logger.getLogger(Repository.class);
+
   public abstract RepositoryTransaction getTransaction();
 
   /**
@@ -321,8 +324,8 @@ private void deleteConnectionsAndJobs(List<MConnection> connections,
    * @param newConnector New properties for the Connector that should be
    *                     upgraded.
    */
-  public final void upgradeConnector(MConnector oldConnector,
-    MConnector newConnector) {
+  public final void upgradeConnector(MConnector oldConnector, MConnector newConnector) {
+    LOG.info("Upgrading metadata for connector: " + oldConnector.getUniqueName());
     long connectorID = oldConnector.getPersistenceId();
     newConnector.setPersistenceId(connectorID);
     /* Algorithms:
@@ -388,10 +391,12 @@ public final void upgradeConnector(MConnector oldConnector,
       if(tx != null) {
         tx.close();
       }
+      LOG.info("Metadata upgrade finished for connector: " + oldConnector.getUniqueName());
     }
   }
 
   public final void upgradeFramework(MFramework framework) {
+    LOG.info("Upgrading framework metadata");
     RepositoryTransaction tx = null;
     try {
       MetadataUpgrader upgrader = FrameworkManager.getInstance()
@@ -441,6 +446,7 @@ public final void upgradeFramework(MFramework framework) {
       if(tx != null) {
         tx.close();
       }
+      LOG.info("Framework metadata upgrade finished");
     }
   }