SQOOP-2526: Sqoop2: findbugs: Fix warning in shell module

(Colin Ma via Jarek Jarcec Cecho)

shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java

@@ -40,6 +40,8 @@
  */
 @SuppressWarnings("serial")
 public class CloneJobFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public CloneJobFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java

@@ -39,6 +39,8 @@
  */
 @SuppressWarnings("serial")
 public class CloneLinkFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public CloneLinkFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java

@@ -41,6 +41,8 @@
  */
 @SuppressWarnings("serial")
 public class CreateJobFunction extends  SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public CreateJobFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java

@@ -40,6 +40,8 @@
  */
 @SuppressWarnings("serial")
 public class CreateLinkFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public CreateLinkFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java

@@ -31,6 +31,8 @@
 
 @SuppressWarnings("serial")
 public class CreateRoleFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public CreateRoleFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.java

@@ -29,6 +29,7 @@
  */
 @SuppressWarnings("serial")
 public class DeleteJobFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
 
   @SuppressWarnings("static-access")
   public DeleteJobFunction() {

shell/src/main/java/org/apache/sqoop/shell/DeleteLinkFunction.java

@@ -29,6 +29,8 @@
  */
 @SuppressWarnings("serial")
 public class DeleteLinkFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public DeleteLinkFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java

@@ -29,6 +29,8 @@
 
 @SuppressWarnings("serial")
 public class DeleteRoleFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public DeleteRoleFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/DisableJobFunction.java

@@ -29,6 +29,7 @@
  */
 @SuppressWarnings("serial")
 public class DisableJobFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
 
   @SuppressWarnings("static-access")
   public DisableJobFunction() {

shell/src/main/java/org/apache/sqoop/shell/DisableLinkFunction.java

@@ -29,6 +29,8 @@
  */
 @SuppressWarnings("serial")
 public class DisableLinkFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public DisableLinkFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/EnableJobFunction.java

@@ -29,6 +29,7 @@
  */
 @SuppressWarnings("serial")
 public class EnableJobFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
 
   @SuppressWarnings("static-access")
   public EnableJobFunction() {

shell/src/main/java/org/apache/sqoop/shell/EnableLinkFunction.java

@@ -29,6 +29,8 @@
  */
 @SuppressWarnings("serial")
 public class EnableLinkFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public EnableLinkFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java

@@ -32,6 +32,8 @@
 import static org.apache.sqoop.shell.ShellEnvironment.*;
 
 public class GrantPrivilegeFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public GrantPrivilegeFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java

@@ -33,6 +33,8 @@
 
 @SuppressWarnings("serial")
 public class GrantRoleFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public GrantRoleFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java

@@ -35,6 +35,8 @@
 import static org.apache.sqoop.shell.utils.ConfigFiller.errorMessage;
 
 public class RevokePrivilegeFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public RevokePrivilegeFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java

@@ -33,6 +33,8 @@
 
 @SuppressWarnings("serial")
 public class RevokeRoleFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public RevokeRoleFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/SetOptionFunction.java

@@ -29,6 +29,8 @@
  */
 @SuppressWarnings("serial")
 public class SetOptionFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public SetOptionFunction() {
     this.addOption(OptionBuilder.hasArg()

shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java

@@ -26,6 +26,7 @@
 
 @SuppressWarnings("serial")
 public class SetServerFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
 
   @SuppressWarnings("static-access")
   public SetServerFunction() {

shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java

@@ -33,6 +33,7 @@
 
 @SuppressWarnings("serial")
 public class ShowConnectorFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
 
   @SuppressWarnings("static-access")
   public ShowConnectorFunction() {

shell/src/main/java/org/apache/sqoop/shell/ShowDriverFunction.java

@@ -30,6 +30,8 @@
  */
 @SuppressWarnings("serial")
 public class ShowDriverFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   public ShowDriverFunction() {
   }
 

shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java

@@ -39,6 +39,8 @@
  */
 @SuppressWarnings("serial")
 public class ShowJobFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public ShowJobFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/ShowJobStatusFunction.java

@@ -30,6 +30,7 @@
 
 @SuppressWarnings("serial")
 public class ShowJobStatusFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
 
   @SuppressWarnings("static-access")
   public ShowJobStatusFunction() {

shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java

@@ -41,6 +41,8 @@
  */
 @SuppressWarnings("serial")
 public class ShowLinkFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public ShowLinkFunction() {
     this.addOption(OptionBuilder
@@ -142,7 +144,7 @@ private List<String> getConnectorNames(List<String> connectorIds) {
     for (String connectorId : connectorIds) {
       if (!connectorIdToName.containsKey(connectorId)) {
         try {
-          MConnector connector = client.getConnector(Long.valueOf(connectorId));
+          MConnector connector = client.getConnector(Long.parseLong(connectorId));
           if (connector != null) {
             connectorIdToName.put(connectorId, connector.getUniqueName());
           }

shell/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.java

@@ -29,6 +29,8 @@
  */
 @SuppressWarnings("serial")
 public class ShowOptionFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   /**
    * Construct new object.
    */

shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java

@@ -33,6 +33,8 @@
 
 @SuppressWarnings("serial")
 public class ShowPrincipalFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public ShowPrincipalFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java

@@ -36,6 +36,8 @@
 
 @SuppressWarnings("serial")
 public class ShowPrivilegeFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public ShowPrivilegeFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java

@@ -35,6 +35,8 @@
 
 @SuppressWarnings("serial")
 public class ShowRoleFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public ShowRoleFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/ShowServerFunction.java

@@ -26,6 +26,8 @@
 
 @SuppressWarnings("serial")
 public class ShowServerFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public ShowServerFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java

@@ -32,6 +32,8 @@
 
 @SuppressWarnings("serial")
 public class ShowSubmissionFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public ShowSubmissionFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java

@@ -31,9 +31,9 @@
 
 @SuppressWarnings("serial")
 public class ShowVersionFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
   private VersionResourceRequest versionRequest;
 
-
   @SuppressWarnings("static-access")
   public ShowVersionFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java

@@ -17,10 +17,8 @@
  */
 package org.apache.sqoop.shell;
 
-import java.io.BufferedReader;
+import java.io.*;
-import java.io.File;
+import java.nio.charset.Charset;
-import java.io.FileReader;
-import java.io.IOException;
 import java.util.HashSet;
 import java.util.Iterator;
 
@@ -54,7 +52,7 @@ public final class SqoopShell {
   /**
    * Hash of commands that we want to have in history in all cases.
    */
-  public final static HashSet<String> commandsToKeep;
+  private final static HashSet<String> commandsToKeep;
 
   static {
     commandsToKeep = new HashSet<String>();
@@ -149,26 +147,27 @@ public static void main (String[] args) throws Exception {
    * @throws IOException
    */
   private static void interpretFileContent(File script, Groovysh shell) throws IOException {
-    BufferedReader in = new BufferedReader(new FileReader(script));
+    try (BufferedReader in = new BufferedReader(new InputStreamReader(new FileInputStream(script), Charset.forName("UTF-8")))) {
-    String line;
+      String line;
 
-    // Iterate over all lines and executed them one by one
+      // Iterate over all lines and executed them one by one
-    while ((line = in.readLine()) != null) {
+      while ((line = in.readLine()) != null) {
 
-      // Skip comments and empty lines as we don't need to interpret those
+        // Skip comments and empty lines as we don't need to interpret those
-      if(line.isEmpty() || line.startsWith("#")) {
+        if (line.isEmpty() || line.startsWith("#")) {
-        continue;
+          continue;
-      }
+        }
 
-      // Render shell and command to get user perception that it was run as usual
+        // Render shell and command to get user perception that it was run as usual
-      print(shell.renderPrompt());
+        print(shell.renderPrompt());
-      println(line);
+        println(line);
 
-      // Manually trigger command line parsing
+        // Manually trigger command line parsing
-      Object result = shell.execute(line);
+        Object result = shell.execute(line);
 
-      if (result == null) {
+        if (result == null) {
-        break;
+          break;
+        }
       }
     }
   }

shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java

@@ -34,6 +34,7 @@
 
 @SuppressWarnings("serial")
 public class StartJobFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
   public static final Logger LOG = Logger.getLogger(StartJobFunction.class);
 
   @SuppressWarnings("static-access")
@@ -53,27 +54,10 @@ public Object executeFunction(CommandLine line, boolean isInteractive) {
     // Poll until finished
     if (line.hasOption(Constants.OPT_SYNCHRONOUS) && line.hasOption(Constants.OPT_JID)) {
       long pollTimeout = getPollTimeout();
-      SubmissionCallback callback = new SubmissionCallback() {
-        @Override
-        public void submitted(MSubmission submission) {
-          SubmissionDisplayer.displayHeader(submission);
-          SubmissionDisplayer.displayProgress(submission);
-        }
-
-        @Override
-        public void updated(MSubmission submission) {
-          SubmissionDisplayer.displayProgress(submission);
-        }
-
-        @Override
-        public void finished(MSubmission submission) {
-          SubmissionDisplayer.displayFooter(submission);
-        }
-      };
 
       try {
         //client.startJob(getLong(line, Constants.OPT_JID), callback, pollTimeout);
-        client.startJob(line.getOptionValue(Constants.OPT_JID), callback, pollTimeout);
+        client.startJob(line.getOptionValue(Constants.OPT_JID), new SJFCallback(), pollTimeout);
       } catch (InterruptedException e) {
         throw new SqoopException(ShellError.SHELL_0007, e);
       }
@@ -92,4 +76,22 @@ public void finished(MSubmission submission) {
 
     return Status.OK;
   }
+
+  private static class SJFCallback implements SubmissionCallback {
+    @Override
+    public void submitted(MSubmission submission) {
+      SubmissionDisplayer.displayHeader(submission);
+      SubmissionDisplayer.displayProgress(submission);
+    }
+
+    @Override
+    public void updated(MSubmission submission) {
+      SubmissionDisplayer.displayProgress(submission);
+    }
+
+    @Override
+    public void finished(MSubmission submission) {
+      SubmissionDisplayer.displayFooter(submission);
+    }
+  }
 }

shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java

@@ -29,6 +29,8 @@
 
 @SuppressWarnings("serial")
 public class StopJobFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public StopJobFunction() {
     this.addOption(OptionBuilder.hasArg().withArgName(Constants.OPT_JID)

shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java

@@ -40,6 +40,8 @@
  */
 @SuppressWarnings("serial")
 public class UpdateJobFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public UpdateJobFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java

@@ -39,6 +39,8 @@
  */
 @SuppressWarnings("serial")
 public class UpdateLinkFunction extends SqoopFunction {
+  private static final long serialVersionUID = 1L;
+
   @SuppressWarnings("static-access")
   public UpdateLinkFunction() {
     this.addOption(OptionBuilder

shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java

@@ -180,16 +180,22 @@ public static boolean fillInput(String prefix, MInput input, CommandLine line) t
     // Based on the input type, let's perconfig specific load
     switch (input.getType()) {
     case STRING:
+      assert input instanceof MStringInput;
       return fillInputString(prefix, (MStringInput) input, line);
     case INTEGER:
+      assert input instanceof MIntegerInput;
       return fillInputInteger(prefix, (MIntegerInput) input, line);
     case LONG:
+      assert input instanceof MLongInput;
       return fillInputLong(prefix, (MLongInput) input, line);
     case BOOLEAN:
+      assert input instanceof MBooleanInput;
       return fillInputBoolean(prefix, (MBooleanInput) input, line);
     case MAP:
+      assert input instanceof MMapInput;
       return fillInputMap(prefix, (MMapInput) input, line);
     case ENUM:
+      assert input instanceof MEnumInput;
       return fillInputEnum(prefix, (MEnumInput) input, line);
     default:
       println("Unsupported data type " + input.getType());

shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java

@@ -27,6 +27,7 @@
  */
 @SuppressWarnings("serial")
 public class JobDynamicConfigOptions extends DynamicConfigOptions<MJob> {
+  private static final long serialVersionUID = 1L;
 
   @SuppressWarnings("static-access")
   @Override

shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java

@@ -26,6 +26,7 @@
  */
 @SuppressWarnings("serial")
 public class LinkDynamicConfigOptions extends DynamicConfigOptions<MLink> {
+  private static final long serialVersionUID = 1L;
 
   @SuppressWarnings("static-access")
   @Override

shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java

@@ -33,13 +33,14 @@
  */
 public final class SubmissionDisplayer {
 
-  private final static SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss z");
+  private final static String DATE_FORMAT = "yyyy-MM-dd HH:mm:ss z";
 
   /**
    * On job submission, displays the initial job info
    * @param submission
    */
   public static void displayHeader(MSubmission submission) {
+    SimpleDateFormat dateFormat = new SimpleDateFormat(DATE_FORMAT);
     println("@|bold "+ resourceString(Constants.RES_SUBMISSION_SUBMISSION_DETAIL) +"|@");
 
     print(resourceString(Constants.RES_SUBMISSION_JOB_ID)+": ");
@@ -84,6 +85,7 @@ public static void displayHeader(MSubmission submission) {
    * @param submission
    */
   public static void displayProgress(MSubmission submission) {
+    SimpleDateFormat dateFormat = new SimpleDateFormat(DATE_FORMAT);
     StringBuilder sb = new StringBuilder();
     if(submission.getStatus().isRunning()) {
       sb.append(dateFormat.format(submission.getLastUpdateDate())+": @|green "+submission.getStatus()+ " |@");
@@ -106,6 +108,7 @@ public static void displayProgress(MSubmission submission) {
    * @param submission
    */
   public static void displayFooter(MSubmission submission) {
+    SimpleDateFormat dateFormat = new SimpleDateFormat(DATE_FORMAT);
     if (submission.getStatus().toString().equals(SubmissionStatus.SUCCEEDED.toString())) {
       println(dateFormat.format(submission.getLastUpdateDate())+": @|green "+submission.getStatus()+ " |@");
       Counters counters = submission.getCounters();