github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-09 21:01:20 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-1971: Sqoop2: strURL may not be initialized when calling addDelegationToken

Browse Source 
(Richard Zhou via Abraham Elmahrek)
This commit is contained in:
Abraham Elmahrek 2015-01-08 23:53:15 -08:00
parent 8d25d1fedf
commit aeab9150b2
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
View File

@ -49,7 +49,6 @@
public class ResourceRequest {
private static final Logger LOG = Logger.getLogger(ResourceRequest.class);
private DelegationTokenAuthenticatedURL.Token authToken;
private String strURL;
public ResourceRequest() {
this.authToken = new DelegationTokenAuthenticatedURL.Token();
@ -58,7 +57,6 @@ public ResourceRequest() {
public ResourceRequest(DelegationTokenAuthenticatedURL.Token token) {
this.authToken = token == null ? new DelegationTokenAuthenticatedURL.Token() : token;
}
protected String doHttpRequest(String strURL, String method) {
return doHttpRequest(strURL, method, "");
}
@ -67,7 +65,6 @@ protected String doHttpRequest(String strURL, String method, String data) {
DataOutputStream wr = null;
BufferedReader reader = null;
try {
this.strURL = strURL;
URL url = new URL(strURL);
HttpURLConnection conn = new DelegationTokenAuthenticatedURL().openConnection(url, authToken);
@ -183,10 +180,10 @@ public String delete(String url) {
return doHttpRequest(url, HttpMethod.DELETE);
}
public Token<?>[] addDelegationTokens(String renewer,
public Token<?>[] addDelegationTokens(String strURL, String renewer,
Credentials credentials) throws IOException {
Token<?>[] tokens = null;
Text dtService = getDelegationTokenService();
Text dtService = getDelegationTokenService(strURL);
Token<?> token = credentials.getToken(dtService);
if (token == null) {
URL url = new URL(strURL);
@ -212,7 +209,7 @@ public HttpURLConnection configure(HttpURLConnection conn) throws IOException {
return tokens;
}
private Text getDelegationTokenService() throws IOException {
private Text getDelegationTokenService(String strURL) throws IOException {
URL url = new URL(strURL);
InetSocketAddress addr = new InetSocketAddress(url.getHost(),
url.getPort());