SQOOP-2555: Sqoop2: Findbugs: Add filter for the unnecessary warning

(Colin Ma via Jarek Jarcec Cecho)

connector/connector-kite/pom.xml

@@ -71,6 +71,10 @@ limitations under the License.
       <artifactId>powermock-api-mockito</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
 
     <!-- Kite required modules -->
     <dependency>

connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java

@@ -47,6 +47,7 @@
  * The class arranges to perform dataset operations (without thread safety
  * guarantee).
  */
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class KiteDatasetExecutor {
 
   private final Dataset<GenericRecord> dataset;

connector/connector-sdk/pom.xml

@@ -53,6 +53,10 @@ limitations under the License.
       <groupId>org.apache.avro</groupId>
       <artifactId>avro</artifactId>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
   </dependencies>
 
 </project>

connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java

@@ -60,6 +60,7 @@
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class SqoopIDFUtils {
 
   public static final String NULL_VALUE = "NULL";

connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java

@@ -59,6 +59,7 @@
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class AVROIntermediateDataFormat extends IntermediateDataFormat<GenericRecord> {
 
   private Schema avroSchema;

connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java

@@ -46,6 +46,7 @@
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class JSONIntermediateDataFormat extends IntermediateDataFormat<JSONObject> {
 
   // need this default constructor for reflection magic used in execution engine

core/pom.xml

@@ -57,6 +57,10 @@ limitations under the License.
       <groupId>org.apache.sqoop</groupId>
       <artifactId>connector-sdk</artifactId>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
   </dependencies>
 
   <build>

core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java

@@ -35,6 +35,7 @@
 
 import static org.apache.sqoop.core.ConfigurationConstants.PROPERTIES_PROVIDER_SLEEP;
 
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("IS2_INCONSISTENT_SYNC")
 public class PropertiesConfigurationProvider implements ConfigurationProvider {
 
   private static final Logger LOG =

core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java

@@ -46,6 +46,7 @@
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("IS2_INCONSISTENT_SYNC")
 public class SqoopConfiguration implements Reconfigurable {
 
   /**

core/src/main/java/org/apache/sqoop/driver/JobManager.java

@@ -51,6 +51,7 @@
 import org.apache.sqoop.submission.SubmissionStatus;
 import org.apache.sqoop.utils.ClassUtils;
 
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("IS2_INCONSISTENT_SYNC")
 public class JobManager implements Reconfigurable {
   /**
    * Logger object.

core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java

@@ -37,7 +37,7 @@
 import org.apache.sqoop.core.SqoopConfiguration;
 import org.apache.sqoop.utils.ClassUtils;
 
-
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("IS2_INCONSISTENT_SYNC")
 public class JdbcRepositoryProvider implements RepositoryProvider {
 
   private static final Logger LOG = Logger.getLogger(JdbcRepositoryProvider.class);

execution/mapreduce/pom.xml

@@ -72,7 +72,10 @@ limitations under the License.
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
     </dependency>
-
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
     <!-- See profiles for Hadoop specific dependencies -->
 
   </dependencies>

execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java

@@ -46,6 +46,7 @@
 import org.apache.sqoop.job.io.SqoopWritable;
 import org.apache.sqoop.utils.ClassUtils;
 
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class SqoopOutputFormatLoadExecutor {
 
   public static final Logger LOG =

server/pom.xml

@@ -132,6 +132,10 @@ limitations under the License.
       <groupId>com.googlecode.json-simple</groupId>
       <artifactId>json-simple</artifactId>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
   </dependencies>
 
   <build>

server/src/main/java/org/apache/sqoop/server/ServerInitializer.java

@@ -28,6 +28,7 @@
  * Initializes the Sqoop server. This listener is also responsible for
  * cleaning up any resources occupied by the server during the system shutdown.
  */
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("DM_EXIT")
 public class ServerInitializer implements ServletContextListener {
 
   private static final Logger LOG = Logger.getLogger(ServerInitializer.class);

shell/pom.xml

@@ -76,6 +76,10 @@ limitations under the License.
       <artifactId>groovy-all</artifactId>
       <version>1.8.5</version>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
   </dependencies>
 
   <profiles>

shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java

@@ -30,6 +30,7 @@
 import static org.apache.sqoop.shell.ShellEnvironment.*;
 
 @SuppressWarnings("serial")
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("SE_BAD_FIELD")
 public class ShowVersionFunction extends SqoopFunction {
   private static final long serialVersionUID = 1L;
   private VersionResourceRequest versionRequest;