From a13343b34536e6ea79253ecece29ad61124802b7 Mon Sep 17 00:00:00 2001
From: Jarek Jarcec Cecho <jarcec@apache.org>
Date: Tue, 8 Sep 2015 12:27:34 +0200
Subject: [PATCH] SQOOP-2555: Sqoop2: Findbugs: Add filter for the unnecessary
 warning

(Colin Ma via Jarek Jarcec Cecho)
---
 connector/connector-kite/pom.xml                             | 4 ++++
 .../org/apache/sqoop/connector/kite/KiteDatasetExecutor.java | 1 +
 connector/connector-sdk/pom.xml                              | 4 ++++
 .../org/apache/sqoop/connector/common/SqoopIDFUtils.java     | 1 +
 .../sqoop/connector/idf/AVROIntermediateDataFormat.java      | 1 +
 .../sqoop/connector/idf/JSONIntermediateDataFormat.java      | 1 +
 core/pom.xml                                                 | 4 ++++
 .../apache/sqoop/core/PropertiesConfigurationProvider.java   | 1 +
 .../main/java/org/apache/sqoop/core/SqoopConfiguration.java  | 1 +
 core/src/main/java/org/apache/sqoop/driver/JobManager.java   | 1 +
 .../org/apache/sqoop/repository/JdbcRepositoryProvider.java  | 2 +-
 execution/mapreduce/pom.xml                                  | 5 ++++-
 .../apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java   | 1 +
 server/pom.xml                                               | 4 ++++
 .../main/java/org/apache/sqoop/server/ServerInitializer.java | 1 +
 shell/pom.xml                                                | 4 ++++
 .../java/org/apache/sqoop/shell/ShowVersionFunction.java     | 1 +
 17 files changed, 35 insertions(+), 2 deletions(-)

diff --git a/connector/connector-kite/pom.xml b/connector/connector-kite/pom.xml
index 41441f55..ff3e0c89 100644
--- a/connector/connector-kite/pom.xml
+++ b/connector/connector-kite/pom.xml
@@ -71,6 +71,10 @@ limitations under the License.
       <artifactId>powermock-api-mockito</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
 
     <!-- Kite required modules -->
     <dependency>
diff --git a/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java b/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java
index 6aa28be2..0f779641 100644
--- a/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java
+++ b/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java
@@ -47,6 +47,7 @@
  * The class arranges to perform dataset operations (without thread safety
  * guarantee).
  */
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class KiteDatasetExecutor {
 
   private final Dataset<GenericRecord> dataset;
diff --git a/connector/connector-sdk/pom.xml b/connector/connector-sdk/pom.xml
index c888aa02..5e207134 100644
--- a/connector/connector-sdk/pom.xml
+++ b/connector/connector-sdk/pom.xml
@@ -53,6 +53,10 @@ limitations under the License.
       <groupId>org.apache.avro</groupId>
       <artifactId>avro</artifactId>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
   </dependencies>
 
 </project>
diff --git a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java
index 52ff2b86..9b0885ad 100644
--- a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java
+++ b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java
@@ -60,6 +60,7 @@
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class SqoopIDFUtils {
 
   public static final String NULL_VALUE = "NULL";
diff --git a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java
index 68eb6eb9..d78fa8b7 100644
--- a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java
+++ b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java
@@ -59,6 +59,7 @@
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class AVROIntermediateDataFormat extends IntermediateDataFormat<GenericRecord> {
 
   private Schema avroSchema;
diff --git a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java
index 9708c058..8db4d3da 100644
--- a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java
+++ b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java
@@ -46,6 +46,7 @@
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class JSONIntermediateDataFormat extends IntermediateDataFormat<JSONObject> {
 
   // need this default constructor for reflection magic used in execution engine
diff --git a/core/pom.xml b/core/pom.xml
index 0a8ec097..f7498905 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -57,6 +57,10 @@ limitations under the License.
       <groupId>org.apache.sqoop</groupId>
       <artifactId>connector-sdk</artifactId>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
   </dependencies>
 
   <build>
diff --git a/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java b/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java
index 2e2d068d..7b06152a 100644
--- a/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java
+++ b/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java
@@ -35,6 +35,7 @@
 
 import static org.apache.sqoop.core.ConfigurationConstants.PROPERTIES_PROVIDER_SLEEP;
 
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("IS2_INCONSISTENT_SYNC")
 public class PropertiesConfigurationProvider implements ConfigurationProvider {
 
   private static final Logger LOG =
diff --git a/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java b/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
index 8f9c445d..04da05f0 100644
--- a/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
+++ b/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
@@ -46,6 +46,7 @@
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("IS2_INCONSISTENT_SYNC")
 public class SqoopConfiguration implements Reconfigurable {
 
   /**
diff --git a/core/src/main/java/org/apache/sqoop/driver/JobManager.java b/core/src/main/java/org/apache/sqoop/driver/JobManager.java
index 44416c49..fdd48f1f 100644
--- a/core/src/main/java/org/apache/sqoop/driver/JobManager.java
+++ b/core/src/main/java/org/apache/sqoop/driver/JobManager.java
@@ -51,6 +51,7 @@
 import org.apache.sqoop.submission.SubmissionStatus;
 import org.apache.sqoop.utils.ClassUtils;
 
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("IS2_INCONSISTENT_SYNC")
 public class JobManager implements Reconfigurable {
   /**
    * Logger object.
diff --git a/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java b/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
index 011527f3..1e0e31d6 100644
--- a/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
+++ b/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
@@ -37,7 +37,7 @@
 import org.apache.sqoop.core.SqoopConfiguration;
 import org.apache.sqoop.utils.ClassUtils;
 
-
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("IS2_INCONSISTENT_SYNC")
 public class JdbcRepositoryProvider implements RepositoryProvider {
 
   private static final Logger LOG = Logger.getLogger(JdbcRepositoryProvider.class);
diff --git a/execution/mapreduce/pom.xml b/execution/mapreduce/pom.xml
index 814f2ce4..4fc3046c 100644
--- a/execution/mapreduce/pom.xml
+++ b/execution/mapreduce/pom.xml
@@ -72,7 +72,10 @@ limitations under the License.
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
     </dependency>
-
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
     <!-- See profiles for Hadoop specific dependencies -->
 
   </dependencies>
diff --git a/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java b/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
index c9d6f104..d94b658a 100644
--- a/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
+++ b/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
@@ -46,6 +46,7 @@
 import org.apache.sqoop.job.io.SqoopWritable;
 import org.apache.sqoop.utils.ClassUtils;
 
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("PZLA_PREFER_ZERO_LENGTH_ARRAYS")
 public class SqoopOutputFormatLoadExecutor {
 
   public static final Logger LOG =
diff --git a/server/pom.xml b/server/pom.xml
index 59663faf..53307f86 100644
--- a/server/pom.xml
+++ b/server/pom.xml
@@ -132,6 +132,10 @@ limitations under the License.
       <groupId>com.googlecode.json-simple</groupId>
       <artifactId>json-simple</artifactId>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
   </dependencies>
 
   <build>
diff --git a/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java b/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java
index 48963f33..70bb6ee2 100644
--- a/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java
+++ b/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java
@@ -28,6 +28,7 @@
  * Initializes the Sqoop server. This listener is also responsible for
  * cleaning up any resources occupied by the server during the system shutdown.
  */
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("DM_EXIT")
 public class ServerInitializer implements ServletContextListener {
 
   private static final Logger LOG = Logger.getLogger(ServerInitializer.class);
diff --git a/shell/pom.xml b/shell/pom.xml
index a699f71e..f54160f6 100644
--- a/shell/pom.xml
+++ b/shell/pom.xml
@@ -76,6 +76,10 @@ limitations under the License.
       <artifactId>groovy-all</artifactId>
       <version>1.8.5</version>
     </dependency>
+    <dependency>
+      <groupId>net.sourceforge.findbugs</groupId>
+      <artifactId>annotations</artifactId>
+    </dependency>
   </dependencies>
 
   <profiles>
diff --git a/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java b/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java
index 28d5de70..16452b5a 100644
--- a/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java
+++ b/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java
@@ -30,6 +30,7 @@
 import static org.apache.sqoop.shell.ShellEnvironment.*;
 
 @SuppressWarnings("serial")
+@edu.umd.cs.findbugs.annotations.SuppressWarnings("SE_BAD_FIELD")
 public class ShowVersionFunction extends SqoopFunction {
   private static final long serialVersionUID = 1L;
   private VersionResourceRequest versionRequest;