diff --git a/client/src/main/java/org/apache/sqoop/client/SqoopClient.java b/client/src/main/java/org/apache/sqoop/client/SqoopClient.java index bac7fe86..e71d3ef0 100644 --- a/client/src/main/java/org/apache/sqoop/client/SqoopClient.java +++ b/client/src/main/java/org/apache/sqoop/client/SqoopClient.java @@ -806,9 +806,9 @@ private Status applyLinkValidations(ValidationResultBean bean, MLink link) { ConfigValidationResult linkConfig = bean.getValidationResults()[0]; // Apply validation results ConfigUtils.applyValidation(link.getConnectorLinkConfig(), linkConfig); - String linkName = bean.getName(); - if (linkName != null) { - link.setName(linkName); + Long id = bean.getId(); + if (id != null) { + link.setPersistenceId(id); } return Status.getWorstStatus(linkConfig.getStatus()); } @@ -830,9 +830,9 @@ private Status applyJobValidations(ValidationResultBean bean, MJob job) { driver ); - String jobName = bean.getName(); - if(jobName != null) { - job.setName(jobName); + Long id = bean.getId(); + if(id != null) { + job.setPersistenceId(id); } return Status.getWorstStatus(fromConfig.getStatus(), toConfig.getStatus(), driver.getStatus()); diff --git a/common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java b/common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java index 09ea847e..b328a25f 100644 --- a/common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java +++ b/common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java @@ -38,11 +38,12 @@ public class ValidationResultBean implements JsonBean { private static final String VALIDATION_RESULT = "validation-result"; + private static final String ID = "id"; private static final String STATUS = "status"; private static final String MESSAGE = "message"; private ConfigValidationResult[] results; - private String name; + private Long id; public ValidationResultBean() { // Empty, for restore @@ -59,12 +60,12 @@ public ConfigValidationResult[] getValidationResults() { return results.clone(); } - public String getName() { - return name; + public void setId(Long id) { + this.id = id; } - public void setName(String name) { - this.name = name; + public Long getId() { + return id; } @SuppressWarnings("unchecked") @@ -79,8 +80,8 @@ public JSONObject extract(boolean skipSensitive) { JSONObject object = new JSONObject(); object.put(VALIDATION_RESULT, array); - if(name != null) { - object.put(NAME, name); + if(id != null) { + object.put(ID, id); } return object; } @@ -123,8 +124,8 @@ public void restore(JSONObject jsonObject) { for(Object item : array) { results[i++] = restoreValidationResult((JSONObject) item); } - if(jsonObject.containsKey(NAME)) { - name = JSONUtils.getString(jsonObject, NAME); + if(jsonObject.containsKey(ID)) { + id = JSONUtils.getLong(jsonObject, ID); } } diff --git a/common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java b/common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java index 8b507971..0381c7d5 100644 --- a/common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java +++ b/common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java @@ -71,11 +71,11 @@ public void testTwoMessages() { @Test public void testId() { - String name = transfer("testName"); - assertEquals("testName", name); + long id = transfer(10L); + assertEquals(10L, id); - String nameNull = transfer((String)null); - assertNull(nameNull); + Long idNull = transfer((Long)null); + assertNull(idNull); } public void verifyResultA(ConfigValidationResult result) { @@ -107,9 +107,9 @@ public ConfigValidationResult getResultA() { } - private String transfer(String name) { + private Long transfer(Long id) { ValidationResultBean bean = new ValidationResultBean(new ConfigValidationResult[0]); - bean.setName(name); + bean.setId(id); JSONObject json = bean.extract(false); String string = json.toString(); @@ -118,7 +118,7 @@ private String transfer(String name) { ValidationResultBean retrievedBean = new ValidationResultBean(); retrievedBean.restore(retrievedJson); - return retrievedBean.getName(); + return retrievedBean.getId(); } private ConfigValidationResult[] transfer(ConfigValidationResult [] results) { diff --git a/server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b/server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java index 7fa6a3b0..666116e6 100644 --- a/server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java +++ b/server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java @@ -250,7 +250,7 @@ private JsonBean createUpdateJob(RequestContext ctx, boolean create) { postedJob.setCreationUser(username); postedJob.setLastUpdateUser(username); repository.createJob(postedJob); - validationResultBean.setName(postedJob.getName()); + validationResultBean.setId(postedJob.getPersistenceId()); } else { AuditLoggerManager.getInstance().logAuditEvent(ctx.getUserName(), ctx.getRequest().getRemoteAddr(), "update", "job", diff --git a/server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b/server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java index 189293aa..cc07fc85 100644 --- a/server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java +++ b/server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java @@ -174,7 +174,7 @@ private JsonBean createUpdateLink(RequestContext ctx, boolean create) { postedLink.setCreationUser(username); postedLink.setLastUpdateUser(username); repository.createLink(postedLink); - linkValidationBean.setName(postedLink.getName()); + linkValidationBean.setId(postedLink.getPersistenceId()); } else { AuditLoggerManager.getInstance().logAuditEvent(ctx.getUserName(), ctx.getRequest().getRemoteAddr(), "update", "link",