github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-08 07:11:01 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-1476: Generic JDBC Connector - DB connections not closed

Browse Source 
(Claire Fautsch via Jarek Jarcec Cecho)
This commit is contained in:
Jarek Jarcec Cecho 2014-09-01 15:27:18 +02:00 committed by Abraham Elmahrek
parent 51a07bc352
commit 8fee134f7f
2 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
View File

@ -111,6 +111,9 @@ public Schema getSchema(InitializerContext context, ConnectionConfiguration conn
LOG.info("Ignoring exception while closing ResultSet", e);
}
}
if (executor != null) {
executor.close();
}
}
}

19
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java
View File

@ -48,14 +48,17 @@ private void moveDataToDestinationTable(ConnectionConfiguration connectorConf,
connectorConf.connection.connectionString,
connectorConf.connection.username,
connectorConf.connection.password);
if(success) {
LOG.info("Job completed, transferring data from stage fromTable to " +
"destination fromTable.");
executor.migrateData(stageTableName, tableName);
} else {
LOG.warn("Job failed, clearing stage fromTable.");
executor.deleteTableData(stageTableName);
try {
if(success) {
LOG.info("Job completed, transferring data from stage fromTable to " +
"destination fromTable.");
executor.migrateData(stageTableName, tableName);
} else {
LOG.warn("Job failed, clearing stage fromTable.");
executor.deleteTableData(stageTableName);
}
} finally {
executor.close();
}
}