github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-02 23:21:22 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-3153: Sqoop export with --as-<spec_file_format> error message could be more verbose

Browse Source 
(Ferenc Szabo via Szabolcs Vasas)
This commit is contained in:
Szabolcs Vasas 2017-12-15 09:29:07 +01:00
parent c975dc4c3b
commit 779eb01de4
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/java/org/apache/sqoop/tool/BaseSqoopTool.java
View File

@ -312,7 +312,7 @@ protected void destroy(SqoopOptions sqoopOpts) {
}
/**
* Examines a subset of the arrray presented, and determines if it
* Examines a subset of the array presented, and determines if it
* contains any non-empty arguments. If so, logs the arguments
* and returns true.
*

32
src/java/org/apache/sqoop/tool/ExportTool.java
View File

@ -19,6 +19,8 @@
package org.apache.sqoop.tool;
import java.io.IOException;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import org.apache.commons.cli.CommandLine;
@ -41,6 +43,16 @@
public class ExportTool extends com.cloudera.sqoop.tool.BaseSqoopTool {
public static final Log LOG = LogFactory.getLog(ExportTool.class.getName());
public static final String NOT_SUPPORTED_FILE_FORMAT_ERROR_MSG = "Please note that the export tool " +
"detects the file format automatically and does not support it as an argument: %s";
private final List<String> unsupportedArguments =
Collections.unmodifiableList(
Arrays.asList(
BaseSqoopTool.FMT_PARQUETFILE_ARG,
BaseSqoopTool.FMT_AVRODATAFILE_ARG,
BaseSqoopTool.FMT_SEQUENCEFILE_ARG)
);
private CodeGenTool codeGenerator;
@ -383,6 +395,26 @@ public void validateOptions(SqoopOptions options)
vaildateDirectExportOptions(options);
}
@Override
/** {@inheritDoc} */
protected boolean hasUnrecognizedArgs(String [] argv, int offset, int len) {
boolean unrecognizedArgs = super.hasUnrecognizedArgs(argv, offset, len);
for (String arg : argv) {
if (unsupportedArguments.contains(stripLeadingHyphens(arg))) {
LOG.error(String.format(NOT_SUPPORTED_FILE_FORMAT_ERROR_MSG, arg));
}
}
return unrecognizedArgs;
}
private String stripLeadingHyphens(String arg) {
if (arg != null
&& arg.startsWith("--")) {
return arg.substring(2);
}
return arg;
}
void vaildateDirectExportOptions(SqoopOptions options) throws InvalidOptionsException {
if (options.isDirect()) {
validateHasDirectConnectorOption(options);