github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-19 02:10:54 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-2487: Sqoop2: ConnectorTestCase have wrong order of arguments in assertEquals

Browse Source 
(Jarek Jarcec Cecho via Abraham Elmahrek)
This commit is contained in:
Abraham Elmahrek 2015-08-17 13:54:54 -07:00
parent 9ecd944dc5
commit 58b2d1c1c4
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
View File

@ -20,8 +20,6 @@
import static org.testng.Assert.assertEquals; import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertNotSame; import static org.testng.Assert.assertNotSame;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.mapred.JobConf;
import org.apache.log4j.Logger; import org.apache.log4j.Logger;
import org.apache.sqoop.client.SubmissionCallback; import org.apache.sqoop.client.SubmissionCallback;
import org.apache.sqoop.common.test.asserts.ProviderAsserts; import org.apache.sqoop.common.test.asserts.ProviderAsserts;
@ -38,8 +36,6 @@
import org.apache.sqoop.test.data.Cities; import org.apache.sqoop.test.data.Cities;
import org.apache.sqoop.test.data.ShortStories; import org.apache.sqoop.test.data.ShortStories;
import org.apache.sqoop.test.data.UbuntuReleases; import org.apache.sqoop.test.data.UbuntuReleases;
import org.apache.sqoop.test.hadoop.HadoopMiniClusterRunner;
import org.apache.sqoop.test.hadoop.HadoopRunnerFactory;
import org.apache.sqoop.validation.Status; import org.apache.sqoop.validation.Status;
import org.testng.annotations.AfterSuite; import org.testng.annotations.AfterSuite;
import org.testng.annotations.BeforeSuite; import org.testng.annotations.BeforeSuite;
@ -257,8 +253,8 @@ protected void assertRowInCities(Object... values) {
* @param link * @param link
*/ */
protected void saveLink(MLink link) { protected void saveLink(MLink link) {
assertEquals(Status.OK, getClient().saveLink(link)); assertEquals(getClient().saveLink(link), Status.OK);
assertNotSame(MPersistableEntity.PERSISTANCE_ID_DEFAULT, link.getPersistenceId()); assertNotSame(link.getPersistenceId(), MPersistableEntity.PERSISTANCE_ID_DEFAULT);
} }
/** /**
@ -269,8 +265,8 @@ protected void saveLink(MLink link) {
* @param job * @param job
*/ */
protected void saveJob(MJob job) { protected void saveJob(MJob job) {
assertEquals(Status.OK, getClient().saveJob(job)); assertEquals(getClient().saveJob(job), Status.OK);
assertNotSame(MPersistableEntity.PERSISTANCE_ID_DEFAULT, job.getPersistenceId()); assertNotSame(job.getPersistenceId(), MPersistableEntity.PERSISTANCE_ID_DEFAULT);
} }
/** /**
@ -286,7 +282,7 @@ protected void executeJob(long jid) throws Exception {
LOG.error("Submission has failed: " + finalSubmission.getError().getErrorSummary()); LOG.error("Submission has failed: " + finalSubmission.getError().getErrorSummary());
LOG.error("Corresponding error details: " + finalSubmission.getError().getErrorDetails()); LOG.error("Corresponding error details: " + finalSubmission.getError().getErrorDetails());
} }
assertEquals(SubmissionStatus.SUCCEEDED, finalSubmission.getStatus(), assertEquals(finalSubmission.getStatus(), SubmissionStatus.SUCCEEDED,
"Submission finished with error: " + finalSubmission.getError().getErrorSummary()); "Submission finished with error: " + finalSubmission.getError().getErrorSummary());
} }