github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-03 07:11:02 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-81. Creation of /tmp/sqoop/compile is not multi-user friendly.

Browse Source 
Create nonce dirs as /tmp/sqoop-${user.name}/compile.
Remove unused compilation directories at end of execution.
Do not memoize nonce compilation directory names in metastore.

From: Aaron Kimball <aaron@cloudera.com>

git-svn-id: https://svn.apache.org/repos/asf/incubator/sqoop/trunk@1149975 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andrew Bayer 2011-07-22 20:04:16 +00:00
parent 899216e175
commit 56e3553f40
1 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/java/com/cloudera/sqoop/SqoopOptions.java
View File

@ -116,6 +116,10 @@ public enum IncrementalMode {
@StoredAsProperty("codegen.output.dir") private String codeOutputDir;
@StoredAsProperty("codegen.compile.dir") private String jarOutputDir;
// Boolean specifying whether jarOutputDir is a nonce tmpdir (true), or
// explicitly set by the user (false). If the former, disregard any value
// for jarOutputDir saved in the metastore.
@StoredAsProperty("codegen.auto.compile.dir") private boolean jarDirIsAuto;
private String hadoopHome; // not serialized to metastore.
@StoredAsProperty("db.split.column") private String splitByCol;
@StoredAsProperty("db.where.clause") private String whereClause;
@ -428,6 +432,14 @@ public void loadProperties(Properties props) {
this.password = props.getProperty("db.password", this.password);
}
if (this.jarDirIsAuto) {
// We memoized a user-specific nonce dir for compilation to the data
// store. Disregard that setting and create a new nonce dir.
String localUsername = System.getProperty("user.name", "unknown");
this.jarOutputDir = getNonceJarDir(tmpDir + "sqoop-" + localUsername
+ "/compile");
}
String colListStr = props.getProperty("db.column.list", null);
if (null != colListStr) {
this.columns = listToArray(colListStr);
@ -554,7 +566,9 @@ public String getTempDir() {
/**
* Return the name of a directory that does not exist before
* calling this method, and does exist afterward. We should be
* the only client of this directory.
* the only client of this directory. If this directory is not
* used during the lifetime of the JVM, schedule it to be removed
* when the JVM exits.
*/
private static String getNonceJarDir(String tmpBase) {
@ -576,6 +590,9 @@ private static String getNonceJarDir(String tmpBase) {
if (hashDir.mkdirs()) {
// We created the directory. Use it.
// If this directory is not actually filled with files, delete it
// when the JVM quits.
hashDir.deleteOnExit();
break;
}
}
@ -624,7 +641,10 @@ private void initDefaults(Configuration baseConfiguration) {
}
this.tmpDir = myTmpDir;
this.jarOutputDir = getNonceJarDir(tmpDir + "sqoop/compile");
String localUsername = System.getProperty("user.name", "unknown");
this.jarOutputDir = getNonceJarDir(tmpDir + "sqoop-" + localUsername
+ "/compile");
this.jarDirIsAuto = true;
this.layout = FileLayout.TextFile;
this.areDelimsManuallySet = false;
@ -941,6 +961,7 @@ public String getJarOutputDir() {
public void setJarOutputDir(String outDir) {
this.jarOutputDir = outDir;
this.jarDirIsAuto = false;
}
/**