From 53cb6caa705d1c6bcb52e0f61896d546b4d68220 Mon Sep 17 00:00:00 2001 From: Bilung Lee Date: Mon, 17 Dec 2012 13:24:40 -0800 Subject: [PATCH] SQOOP-781 Improve logging in GenericJdbcImportInitializer (Jarek Jarcec Cecho) --- .../jdbc/GenericJdbcImportInitializer.java | 24 ++++++++++--------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java b/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java index 3ce6bb90..3b697b62 100644 --- a/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java +++ b/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java @@ -191,15 +191,15 @@ private void configurePartitionProperties(MutableContext context, ConnectionConf rs.next(); - context.setString( - GenericJdbcConnectorConstants.CONNECTOR_JDBC_PARTITION_COLUMNTYPE, - String.valueOf(rsmd.getColumnType(1))); - context.setString( - GenericJdbcConnectorConstants.CONNECTOR_JDBC_PARTITION_MINVALUE, - rs.getString(1)); - context.setString( - GenericJdbcConnectorConstants.CONNECTOR_JDBC_PARTITION_MAXVALUE, - rs.getString(2)); + int columnType = rsmd.getColumnType(1); + String min = rs.getString(1); + String max = rs.getString(2); + + LOG.info("Boundaries: min=" + min + ", max=" + max + ", columnType=" + columnType); + + context.setInteger(GenericJdbcConnectorConstants.CONNECTOR_JDBC_PARTITION_COLUMNTYPE, columnType); + context.setString(GenericJdbcConnectorConstants.CONNECTOR_JDBC_PARTITION_MINVALUE, min); + context.setString(GenericJdbcConnectorConstants.CONNECTOR_JDBC_PARTITION_MAXVALUE, max); } catch (SQLException e) { throw new SqoopException( @@ -290,8 +290,10 @@ private void configureTableProperties(MutableContext context, ConnectionConfigur GenericJdbcConnectorError.GENERIC_JDBC_CONNECTOR_0008); } - context.setString(GenericJdbcConnectorConstants.CONNECTOR_JDBC_DATA_SQL, - dataSql.toString()); + LOG.info("Using dataSql: " + dataSql); + LOG.info("Field names: " + fieldNames); + + context.setString(GenericJdbcConnectorConstants.CONNECTOR_JDBC_DATA_SQL, dataSql); context.setString(Constants.JOB_ETL_FIELD_NAMES, fieldNames); } }