From 3f8252a28c95040f033c01a1a0427b08a9787a1c Mon Sep 17 00:00:00 2001 From: Andrew Bayer Date: Fri, 22 Jul 2011 20:04:27 +0000 Subject: [PATCH] SQOOP-154. Fix connection leak in OracleManager. From: Arvind Prabhakar git-svn-id: https://svn.apache.org/repos/asf/incubator/sqoop/trunk@1150009 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/com/cloudera/sqoop/manager/OracleManager.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/java/com/cloudera/sqoop/manager/OracleManager.java b/src/java/com/cloudera/sqoop/manager/OracleManager.java index 0ac455c0..82ba1daf 100644 --- a/src/java/com/cloudera/sqoop/manager/OracleManager.java +++ b/src/java/com/cloudera/sqoop/manager/OracleManager.java @@ -565,7 +565,7 @@ public String[] listDatabases() { } try { - discardConnection(false); + close(); } catch (SQLException ex) { LOG.error("Unable to discard connection", ex); } @@ -615,7 +615,7 @@ public String[] listTables() { } try { - discardConnection(false); + close(); } catch (SQLException ex) { LOG.error("Unable to discard connection", ex); } @@ -667,7 +667,7 @@ public String[] getColumnNames(String tableName) { } try { - discardConnection(false); + close(); } catch (SQLException ex) { LOG.error("Unable to discard connection", ex); } @@ -719,7 +719,7 @@ public String getPrimaryKey(String tableName) { } try { - discardConnection(false); + close(); } catch (SQLException ex) { LOG.error("Unable to discard connection", ex); }