From 3c88f553de57a6fc35bc4e2191bcb58384662d72 Mon Sep 17 00:00:00 2001 From: Abraham Elmahrek Date: Wed, 29 Jul 2015 18:47:09 -0700 Subject: [PATCH] SQOOP-2452: Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class (Jarek Jarcec Cecho via Abraham Elmahrek) --- .../sqoop/client/request/ResourceRequest.java | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java b/client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java index a8a7e898..e7f49f44 100644 --- a/client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java +++ b/client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java @@ -183,6 +183,13 @@ public String delete(String url) { return doHttpRequest(url, HttpMethod.DELETE); } + private static class SimpleConnectionConfigurator implements ConnectionConfigurator { + @Override + public HttpURLConnection configure(HttpURLConnection conn) throws IOException { + return conn; + } + } + public Token[] addDelegationTokens(String strURL, String renewer, Credentials credentials) throws IOException { Token[] tokens = null; @@ -190,13 +197,7 @@ public Token[] addDelegationTokens(String strURL, String renewer, Token token = credentials.getToken(dtService); if (token == null) { URL url = new URL(strURL); - DelegationTokenAuthenticatedURL authUrl = - new DelegationTokenAuthenticatedURL(new ConnectionConfigurator() { - @Override - public HttpURLConnection configure(HttpURLConnection conn) throws IOException { - return conn; - } - }); + DelegationTokenAuthenticatedURL authUrl = new DelegationTokenAuthenticatedURL(new SimpleConnectionConfigurator()); try { token = authUrl.getDelegationToken(url, authToken, renewer); if (token != null) {