github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-04 05:51:17 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-170. Capturing causal exception for logging.

Browse Source 
From: Arvind Prabhakar <arvind@cloudera.com>

git-svn-id: https://svn.apache.org/repos/asf/incubator/sqoop/trunk@1150024 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andrew Bayer 2011-07-22 20:04:32 +00:00
parent 67dce5cc36
commit 3bbb4a6314
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java
View File

@ -215,7 +215,7 @@ conf, getConnection(), getDBConf(), conditions, fieldNames,
tableName); tableName);
} }
} catch (SQLException ex) { } catch (SQLException ex) {
throw new IOException(ex.getMessage()); throw new IOException(ex);
} }
} }

8
src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java
View File

@ -98,13 +98,13 @@ public void close(TaskAttemptContext context) throws IOException {
} catch (SQLException ex) { } catch (SQLException ex) {
LOG.warn(StringUtils.stringifyException(ex)); LOG.warn(StringUtils.stringifyException(ex));
} }
throw new IOException(e.getMessage()); throw new IOException(e);
} finally { } finally {
try { try {
statement.close(); statement.close();
connection.close(); connection.close();
} catch (SQLException ex) { } catch (SQLException ex) {
throw new IOException(ex.getMessage()); LOG.error("Unable to close connection", ex);
} }
} }
} }
@ -116,7 +116,7 @@ public void write(K key, V value) throws IOException {
key.write(statement); key.write(statement);
statement.addBatch(); statement.addBatch();
} catch (SQLException e) { } catch (SQLException e) {
e.printStackTrace(); LOG.error("Exception encountered", e);
} }
} }
} }
@ -181,7 +181,7 @@ public RecordWriter<K, V> getRecordWriter(TaskAttemptContext context)
constructQuery(tableName, fieldNames)); constructQuery(tableName, fieldNames));
return new DBRecordWriter(connection, statement); return new DBRecordWriter(connection, statement);
} catch (Exception ex) { } catch (Exception ex) {
throw new IOException(ex.getMessage()); throw new IOException(ex);
} }
} }

2
src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java
View File

@ -165,7 +165,7 @@ public void close() throws IOException {
connection.close(); connection.close();
} }
} catch (SQLException e) { } catch (SQLException e) {
throw new IOException(e.getMessage()); throw new IOException(e);
} }
} }

4
src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
View File

@ -198,7 +198,7 @@ public List<InputSplit> getSplits(JobContext job) throws IOException {
return splitter.split(job.getConfiguration(), results, return splitter.split(job.getConfiguration(), results,
getDBConf().getInputOrderBy()); getDBConf().getInputOrderBy());
} catch (SQLException e) { } catch (SQLException e) {
throw new IOException(e.getMessage()); throw new IOException(e);
} finally { } finally {
// More-or-less ignore SQL exceptions here, but log in case we need it. // More-or-less ignore SQL exceptions here, but log in case we need it.
try { try {
@ -293,7 +293,7 @@ conf, getConnection(), dbConf, dbConf.getInputConditions(),
dbConf.getInputFieldNames(), dbConf.getInputTableName(), dbConf.getInputFieldNames(), dbConf.getInputTableName(),
dbProductName); dbProductName);
} catch (SQLException ex) { } catch (SQLException ex) {
throw new IOException(ex.getMessage()); throw new IOException(ex);
} }
} }

2
src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
View File

@ -65,7 +65,7 @@ protected RecordReader<LongWritable, T> createDBRecordReader(
conf, getConnection(), dbConf, dbConf.getInputConditions(), conf, getConnection(), dbConf, dbConf.getInputConditions(),
dbConf.getInputFieldNames(), dbConf.getInputTableName()); dbConf.getInputFieldNames(), dbConf.getInputTableName());
} catch (SQLException ex) { } catch (SQLException ex) {
throw new IOException(ex.getMessage()); throw new IOException(ex);
} }
} }
} }