diff --git a/common-test/src/main/java/org/apache/sqoop/common/test/db/types/DatabaseType.java b/common-test/src/main/java/org/apache/sqoop/common/test/db/types/DatabaseType.java index 9b22fa70..a9b91804 100644 --- a/common-test/src/main/java/org/apache/sqoop/common/test/db/types/DatabaseType.java +++ b/common-test/src/main/java/org/apache/sqoop/common/test/db/types/DatabaseType.java @@ -89,7 +89,7 @@ public String toString() { String [] ret = new String[values.size()]; int i = 0; for(ExampleValue value : values) { - ret[i++] = value.escapedStringValue; + ret[i++] = value.getEscapedStringValue(); } return ret; } diff --git a/common-test/src/main/java/org/apache/sqoop/common/test/db/types/ExampleValue.java b/common-test/src/main/java/org/apache/sqoop/common/test/db/types/ExampleValue.java index 3612a76f..8c5da70c 100644 --- a/common-test/src/main/java/org/apache/sqoop/common/test/db/types/ExampleValue.java +++ b/common-test/src/main/java/org/apache/sqoop/common/test/db/types/ExampleValue.java @@ -24,21 +24,33 @@ public class ExampleValue { /** * Properly escaped value so that it can be used in INSERT statement. */ - public final String insertStatement; + private String insertStatement; /** * Object value that should be returned from JDBC driver getObject(). */ - public final Object objectValue; + private Object objectValue; /** * Escaped string value that will be stored by HDFS connector. */ - public final String escapedStringValue; + private String escapedStringValue; public ExampleValue(String insertStatement, Object objectValue, String escapedStringValue) { this.insertStatement = insertStatement; this.objectValue = objectValue; this.escapedStringValue = escapedStringValue; } + + public String getInsertStatement() { + return insertStatement; + } + + public Object getObjectValue() { + return objectValue; + } + + public String getEscapedStringValue() { + return escapedStringValue; + } } diff --git a/test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java b/test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java index cdb6f811..aece8cfd 100644 --- a/test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java +++ b/test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java @@ -78,7 +78,7 @@ public void testFrom() throws Exception { int i = 1; for(ExampleValue value: type.values) { - insertRow(false, Integer.toString(i++), value.insertStatement); + insertRow(false, Integer.toString(i++), value.getInsertStatement()); } // RDBMS link @@ -152,9 +152,9 @@ public void testTo() throws Exception { assertEquals(type.values.size(), rowCount()); for(ExampleValue value : type.values) { assertRow( - new Object[] {"value", value.insertStatement}, + new Object[] {"value", value.getInsertStatement()}, false, - value.objectValue); + value.getObjectValue()); } // Clean up testing table