github/sqoop
5
0
Fork 0
mirror of https://github.com/apache/sqoop.git synced 2025-05-06 10:01:30 +08:00
Code Issues Projects Releases Wiki Activity

SQOOP-855: pg_bulkload: NullPointerException will be thrown if user specified invalid path the binary

Browse Source 
(Jarek Jarcec Cecho via Cheolsoo Park)
This commit is contained in:
Cheolsoo Park 2013-01-30 17:10:28 -08:00
parent 144d31e62a
commit 0488503a3a
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
View File

@ -170,6 +170,7 @@ protected void setup(Context context)
thread = new ReadThread(process.getErrorStream()); thread = new ReadThread(process.getErrorStream());
thread.start(); thread.start();
} catch (Exception e) { } catch (Exception e) {
LOG.error("Can't start up pg_bulkload process", e);
cleanup(context); cleanup(context);
doExecuteUpdate("DROP TABLE " + tmpTableName); doExecuteUpdate("DROP TABLE " + tmpTableName);
throw new IOException(e); throw new IOException(e);
@ -200,10 +201,17 @@ protected void cleanup(Context context)
LongWritable taskid = LongWritable taskid =
new LongWritable(context.getTaskAttemptID().getTaskID().getId()); new LongWritable(context.getTaskAttemptID().getTaskID().getId());
context.write(taskid, new Text(tmpTableName)); context.write(taskid, new Text(tmpTableName));
writer.close();
out.close(); if (writer != null) {
writer.close();
}
if (out != null) {
out.close();
}
try { try {
thread.join(); if (thread != null) {
thread.join();
}
} finally { } finally {
// block until the process is done. // block until the process is done.
if (null != process) { if (null != process) {