From 9b948340d70f9fe5626248c4746746a0af1379e4 Mon Sep 17 00:00:00 2001 From: Caleb Maclennan Date: Thu, 6 Feb 2020 15:25:30 +0300 Subject: [PATCH] Ignore dist files in repository, update PRtemplate (#1894) * Ignore all permutations of dist in git * Update PR template to direct contributors The current template is largely being ignored with many PRs coming through with "yes/no". Hopefully the text at the top will actually catch peoples attention and keep the "clutter blindness" down that I think is making people ignore the table entirely. Also the note about dist files is pretty unnecessary with a properly setup gitignore file. --- .github/PULL_REQUEST_TEMPLATE.md | 7 +++---- .gitignore | 5 ++--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 692c42a6..0d85c0e9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,3 +1,6 @@ + + | Q | A | ---------------- | --- | Bug fix? | yes/no @@ -11,7 +14,3 @@ ### Description [Description of the bug or feature] - --- - -#### Please don't submit `/dist` files with your PR! diff --git a/.gitignore b/.gitignore index bf2dedbf..8694f039 100644 --- a/.gitignore +++ b/.gitignore @@ -1,9 +1,8 @@ .DS_Store -dist/electron/* -dist/web/* +dist/ +*/dist/* build/* static/themes/* -src/muya/dist/ src/muya/node_modules/ coverage .vscode