mirror of
https://github.com/harness/drone.git
synced 2025-05-15 16:40:06 +08:00
b7b9f53b0d
This commit contains the following: - Improve and simplify error handling (remove unnecessary wrappers, make it feel like go) - Add extra validation for path creation and resource moving (path has to be within same top space, no top space alias allowed) - Add access logging for rest api and git api
64 lines
1.7 KiB
Go
64 lines
1.7 KiB
Go
// Copyright 2021 Harness Inc. All rights reserved.
|
|
// Use of this source code is governed by the Polyform Free Trial License
|
|
// that can be found in the LICENSE.md file for this repository.
|
|
|
|
package space
|
|
|
|
import (
|
|
"net/http"
|
|
"strconv"
|
|
|
|
"github.com/harness/gitness/internal/api/render"
|
|
"github.com/harness/gitness/internal/api/request"
|
|
"github.com/harness/gitness/internal/store"
|
|
"github.com/harness/gitness/types"
|
|
"github.com/rs/zerolog"
|
|
"github.com/rs/zerolog/hlog"
|
|
)
|
|
|
|
/*
|
|
* Required returns an http.HandlerFunc middleware that resolves the
|
|
* space using the fqsn from the request and injects it into the request.
|
|
* In case the fqsn isn't found or the space doesn't exist an error is rendered.
|
|
*/
|
|
func Required(spaces store.SpaceStore) func(http.Handler) http.Handler {
|
|
return func(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
ctx := r.Context()
|
|
log := hlog.FromRequest(r)
|
|
|
|
ref, err := request.GetSpaceRef(r)
|
|
if err != nil {
|
|
render.BadRequest(w)
|
|
return
|
|
}
|
|
|
|
var space *types.Space
|
|
|
|
// check if ref is spaceId - ASSUMPTION: digit only is no valid space name
|
|
id, err := strconv.ParseInt(ref, 10, 64)
|
|
if err == nil {
|
|
space, err = spaces.Find(ctx, id)
|
|
} else {
|
|
space, err = spaces.FindByPath(ctx, ref)
|
|
}
|
|
|
|
if err != nil {
|
|
log.Debug().Err(err).Msgf("Failed to get space using ref '%s'.", ref)
|
|
|
|
render.UserfiedErrorOrInternal(w, err)
|
|
return
|
|
}
|
|
|
|
// Update the logging context and inject repo in context
|
|
log.UpdateContext(func(c zerolog.Context) zerolog.Context {
|
|
return c.Int64("space_id", space.ID).Str("space_path", space.Path)
|
|
})
|
|
|
|
next.ServeHTTP(w, r.WithContext(
|
|
request.WithSpace(ctx, space),
|
|
))
|
|
})
|
|
}
|
|
}
|