drone/internal/api/middleware/authn/authn.go
Johannes Batzill b7b9f53b0d Improve error handling to match go standards - don't wrap and rethrow, but log and return. Also adds some more validations for path creation and resource moving. Add accesslogging for git and api router (#14)
This commit contains the following:
- Improve and simplify error handling (remove unnecessary wrappers, make it feel like go)
- Add extra validation for path creation and resource moving (path has to be within same top space, no top space alias allowed)
- Add access logging for rest api and git api
2022-09-09 22:08:46 -07:00

58 lines
1.6 KiB
Go

// Copyright 2021 Harness Inc. All rights reserved.
// Use of this source code is governed by the Polyform Free Trial License
// that can be found in the LICENSE.md file for this repository.
package authn
import (
"errors"
"net/http"
"github.com/harness/gitness/internal/api/render"
"github.com/harness/gitness/internal/api/request"
"github.com/harness/gitness/internal/auth/authn"
"github.com/rs/zerolog"
"github.com/rs/zerolog/hlog"
)
/*
* Attempt returns an http.HandlerFunc middleware that authenticates
* the http.Request if authentication payload is available.
*/
func Attempt(authenticator authn.Authenticator) func(http.Handler) http.Handler {
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
log := hlog.FromRequest(r)
user, err := authenticator.Authenticate(r)
if errors.Is(err, authn.ErrNoAuthData) {
// if there was no auth data in the request - continue as is
next.ServeHTTP(w, r)
return
} else if err != nil {
// for any other error we fail
render.Unauthorized(w)
return
} else if user == nil {
// when err == nil user should never be nil!
log.Error().Msg("User is nil eventhough the authenticator didn't return any error!")
render.InternalError(w)
return
}
// Update the logging context and inject user in context
log.UpdateContext(func(c zerolog.Context) zerolog.Context {
return c.Int64("user_id", user.ID).Bool("user_admin", user.Admin)
})
next.ServeHTTP(w, r.WithContext(
request.WithUser(ctx, user),
))
})
}
}