drone/internal/api/handler/space/deletePath.go
Johannes Batzill b7b9f53b0d Improve error handling to match go standards - don't wrap and rethrow, but log and return. Also adds some more validations for path creation and resource moving. Add accesslogging for git and api router (#14)
This commit contains the following:
- Improve and simplify error handling (remove unnecessary wrappers, make it feel like go)
- Add extra validation for path creation and resource moving (path has to be within same top space, no top space alias allowed)
- Add access logging for rest api and git api
2022-09-09 22:08:46 -07:00

48 lines
1.1 KiB
Go

// Copyright 2021 Harness Inc. All rights reserved.
// Use of this source code is governed by the Polyform Free Trial License
// that can be found in the LICENSE.md file for this repository.
package space
import (
"net/http"
"github.com/harness/gitness/internal/api/guard"
"github.com/harness/gitness/internal/api/render"
"github.com/harness/gitness/internal/api/request"
"github.com/harness/gitness/internal/store"
"github.com/harness/gitness/types/enum"
"github.com/rs/zerolog/hlog"
)
/*
* Deletes a given path.
*/
func HandleDeletePath(guard *guard.Guard, spaces store.SpaceStore) http.HandlerFunc {
return guard.Space(
enum.PermissionSpaceEdit,
false,
func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
log := hlog.FromRequest(r)
space, _ := request.SpaceFrom(ctx)
pathId, err := request.GetPathId(r)
if err != nil {
render.BadRequest(w)
return
}
err = spaces.DeletePath(ctx, space.ID, pathId)
if err != nil {
log.Err(err).Int64("path_id", pathId).
Msgf("Failed to delete space path.")
render.UserfiedErrorOrInternal(w, err)
return
}
w.WriteHeader(http.StatusNoContent)
})
}