mirror of
https://github.com/harness/drone.git
synced 2025-05-03 18:12:09 +08:00

* fix merge conflicts * fix merge conflicts * fix review comment * fix review comment * fix review comment * fix: [AH-771]: gitness unit test refactoring * fix: [AH-771]: resolved review comments * fix: [AH-771]: resolved review comments * fix: [AH-771] Registry test refactoring and improvements - Refactored registry metadata test implementations - Improved code organization and readability - Fixed line length issues in test files - Removed unused fields from request.go - Added proper license headers - Fixed linting issues in mock files - Simplified test setup and assertions - Updated wire generation for cmd package - Added nolint:exhaustive directive for package type switch fix: [AH-771] Registry test refactoring and improvements - Refactored registry metadata test implementations - Improved code organization and readability - Fixed line length issues in test files - Removed unused fields from request.go - Added proper license headers - Fixed linting issues in mock files - Simplifi
239 lines
7.5 KiB
Go
239 lines
7.5 KiB
Go
// Copyright 2023 Harness, Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package metadata
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
apiauth "github.com/harness/gitness/app/api/auth"
|
|
"github.com/harness/gitness/app/api/request"
|
|
"github.com/harness/gitness/audit"
|
|
"github.com/harness/gitness/registry/app/api/openapi/contracts/artifact"
|
|
"github.com/harness/gitness/registry/app/api/utils"
|
|
"github.com/harness/gitness/registry/services/webhook"
|
|
registryTypes "github.com/harness/gitness/registry/types"
|
|
"github.com/harness/gitness/types"
|
|
"github.com/harness/gitness/types/enum"
|
|
|
|
"github.com/opencontainers/go-digest"
|
|
"github.com/rs/zerolog/log"
|
|
)
|
|
|
|
func (c *APIController) DeleteArtifactVersion(ctx context.Context, r artifact.DeleteArtifactVersionRequestObject) (
|
|
artifact.DeleteArtifactVersionResponseObject, error) {
|
|
regInfo, err := c.RegistryMetadataHelper.GetRegistryRequestBaseInfo(ctx, "", string(r.RegistryRef))
|
|
if err != nil {
|
|
return artifact.DeleteArtifactVersion400JSONResponse{
|
|
BadRequestJSONResponse: artifact.BadRequestJSONResponse(
|
|
*GetErrorResponse(http.StatusBadRequest, err.Error()),
|
|
),
|
|
}, err
|
|
}
|
|
space, err := c.SpaceFinder.FindByRef(ctx, regInfo.ParentRef)
|
|
if err != nil {
|
|
return artifact.DeleteArtifactVersion400JSONResponse{
|
|
BadRequestJSONResponse: artifact.BadRequestJSONResponse(
|
|
*GetErrorResponse(http.StatusBadRequest, err.Error()),
|
|
),
|
|
}, err
|
|
}
|
|
|
|
session, _ := request.AuthSessionFrom(ctx)
|
|
if err = apiauth.CheckSpaceScope(
|
|
ctx,
|
|
c.Authorizer,
|
|
session,
|
|
space,
|
|
enum.ResourceTypeRegistry,
|
|
enum.PermissionArtifactsDelete,
|
|
); err != nil {
|
|
return artifact.DeleteArtifactVersion403JSONResponse{
|
|
UnauthorizedJSONResponse: artifact.UnauthorizedJSONResponse(
|
|
*GetErrorResponse(http.StatusForbidden, err.Error()),
|
|
),
|
|
}, err
|
|
}
|
|
|
|
repoEntity, err := c.RegistryRepository.GetByParentIDAndName(ctx, regInfo.ParentID, regInfo.RegistryIdentifier)
|
|
if err != nil {
|
|
//nolint:nilerr
|
|
return artifact.DeleteArtifactVersion404JSONResponse{
|
|
NotFoundJSONResponse: artifact.NotFoundJSONResponse(
|
|
*GetErrorResponse(http.StatusNotFound, "registry doesn't exist with this key"),
|
|
),
|
|
}, nil
|
|
}
|
|
|
|
artifactName := string(r.Artifact)
|
|
versionName := string(r.Version)
|
|
registryName := repoEntity.Name
|
|
|
|
image, err := c.ImageStore.GetByRepoAndName(ctx, regInfo.ParentID, regInfo.RegistryIdentifier, artifactName)
|
|
if err != nil {
|
|
//nolint:nilerr
|
|
return artifact.DeleteArtifactVersion404JSONResponse{
|
|
NotFoundJSONResponse: artifact.NotFoundJSONResponse(
|
|
*GetErrorResponse(http.StatusNotFound, "image doesn't exist with this key"),
|
|
),
|
|
}, nil
|
|
}
|
|
|
|
_, err = c.ArtifactStore.GetByName(ctx, image.ID, versionName)
|
|
if err != nil {
|
|
//nolint:nilerr
|
|
return artifact.DeleteArtifactVersion404JSONResponse{
|
|
NotFoundJSONResponse: artifact.NotFoundJSONResponse(
|
|
*GetErrorResponse(http.StatusNotFound, "version doesn't exist with this key"),
|
|
),
|
|
}, nil
|
|
}
|
|
|
|
switch regInfo.PackageType {
|
|
case artifact.PackageTypeDOCKER:
|
|
err = c.deleteTagWithAudit(ctx, regInfo, registryName, session.Principal, artifactName,
|
|
versionName)
|
|
case artifact.PackageTypeHELM:
|
|
err = c.deleteTagWithAudit(ctx, regInfo, registryName, session.Principal, artifactName,
|
|
versionName)
|
|
case artifact.PackageTypeNPM:
|
|
err = c.deleteVersion(ctx, regInfo, artifactName, versionName)
|
|
case artifact.PackageTypeMAVEN:
|
|
err = c.deleteVersion(ctx, regInfo, artifactName, versionName)
|
|
case artifact.PackageTypePYTHON:
|
|
err = c.deleteVersion(ctx, regInfo, artifactName, versionName)
|
|
case artifact.PackageTypeGENERIC:
|
|
err = c.deleteVersion(ctx, regInfo, artifactName, versionName)
|
|
case artifact.PackageTypeNUGET:
|
|
err = fmt.Errorf("delete version not supported for nuget")
|
|
case artifact.PackageTypeRPM:
|
|
err = fmt.Errorf("delete version not supported for rpm")
|
|
default:
|
|
err = fmt.Errorf("unsupported package type: %s", regInfo.PackageType)
|
|
}
|
|
|
|
if err != nil {
|
|
return throwDeleteArtifactVersion500Error(err), err
|
|
}
|
|
|
|
auditErr := c.AuditService.Log(
|
|
ctx,
|
|
session.Principal,
|
|
audit.NewResource(audit.ResourceTypeRegistry, artifactName),
|
|
audit.ActionDeleted,
|
|
regInfo.ParentRef,
|
|
audit.WithData("registry name", registryName),
|
|
audit.WithData("artifact name", artifactName),
|
|
audit.WithData("version name", versionName),
|
|
)
|
|
if auditErr != nil {
|
|
log.Ctx(ctx).Warn().Msgf("failed to insert audit log for delete artifact operation: %s", auditErr)
|
|
}
|
|
|
|
return artifact.DeleteArtifactVersion200JSONResponse{
|
|
SuccessJSONResponse: artifact.SuccessJSONResponse(*GetSuccessResponse()),
|
|
}, nil
|
|
}
|
|
|
|
func (c *APIController) deleteTagWithAudit(
|
|
ctx context.Context, regInfo *registryTypes.RegistryRequestBaseInfo,
|
|
registryName string, principal types.Principal, artifactName string, versionName string,
|
|
) error {
|
|
existingDigest := c.getTagDigest(ctx, regInfo.RegistryID, artifactName, versionName)
|
|
|
|
err := c.TagStore.DeleteTag(ctx, regInfo.RegistryID, artifactName, versionName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if existingDigest != "" {
|
|
payload := webhook.GetArtifactDeletedPayload(ctx, principal.ID, regInfo.RegistryID,
|
|
registryName, versionName, existingDigest.String(), regInfo.RootIdentifier,
|
|
regInfo.PackageType, artifactName, c.URLProvider)
|
|
c.ArtifactEventReporter.ArtifactDeleted(ctx, &payload)
|
|
}
|
|
|
|
return err
|
|
}
|
|
|
|
func (c *APIController) deleteVersion(
|
|
ctx context.Context,
|
|
regInfo *registryTypes.RegistryRequestBaseInfo,
|
|
artifactName string,
|
|
versionName string,
|
|
) error {
|
|
// get the file path based on package type
|
|
filePath, err := utils.GetFilePath(regInfo.PackageType, artifactName, versionName)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get file path: %w", err)
|
|
}
|
|
|
|
err = c.tx.WithTx(
|
|
ctx,
|
|
func(ctx context.Context) error {
|
|
// delete nodes from nodes store
|
|
err = c.fileManager.DeleteNode(ctx, regInfo.RegistryID, filePath)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// delete artifacts from artifacts store
|
|
err = c.ArtifactStore.DeleteByVersionAndImageName(ctx, artifactName, versionName, regInfo.RegistryID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to delete version: %w", err)
|
|
}
|
|
|
|
// delete image if no other artifacts linked
|
|
err = c.ImageStore.DeleteByImageNameIfNoLinkedArtifacts(ctx, regInfo.RegistryID, artifactName)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to delete image: %w", err)
|
|
}
|
|
|
|
return nil
|
|
},
|
|
)
|
|
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func throwDeleteArtifactVersion500Error(err error) artifact.DeleteArtifactVersion500JSONResponse {
|
|
return artifact.DeleteArtifactVersion500JSONResponse{
|
|
InternalServerErrorJSONResponse: artifact.InternalServerErrorJSONResponse(
|
|
*GetErrorResponse(http.StatusInternalServerError, err.Error()),
|
|
),
|
|
}
|
|
}
|
|
|
|
func (c *APIController) getTagDigest(
|
|
ctx context.Context,
|
|
registryID int64,
|
|
imageName string,
|
|
tag string,
|
|
) digest.Digest {
|
|
existingTag, findTagErr := c.TagStore.FindTag(ctx, registryID, imageName, tag)
|
|
if findTagErr == nil && existingTag != nil {
|
|
existingTaggedManifest, getManifestErr := c.ManifestStore.Get(ctx, existingTag.ManifestID)
|
|
if getManifestErr == nil {
|
|
return existingTaggedManifest.Digest
|
|
}
|
|
}
|
|
return ""
|
|
}
|