mirror of
https://github.com/harness/drone.git
synced 2025-05-05 05:51:56 +08:00

This change is a follow up on the effort to remove transactions and sync stores from the database layer, and move them in the application layer. It is addressing the repo + space store. The following changes are included: - Introduce PathStore storing resource paths (repo + space) - Add foreign key from path.repo_id/space_id to repo.id/space.id - Add foreign key from repo/space.parent_id to space.id - Remove repo_sync and space_sync - Move path creation logic to repo/space controller (for both creating primary paths for new repos/spaces, as well as creating alias spaces) - Reimplement repo/space moving on controller layer
143 lines
3.8 KiB
Go
143 lines
3.8 KiB
Go
// Copyright 2022 Harness Inc. All rights reserved.
|
|
// Use of this source code is governed by the Polyform Free Trial License
|
|
// that can be found in the LICENSE.md file for this repository.
|
|
|
|
package repo
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
apiauth "github.com/harness/gitness/internal/api/auth"
|
|
"github.com/harness/gitness/internal/auth"
|
|
"github.com/harness/gitness/internal/paths"
|
|
"github.com/harness/gitness/internal/store/database/dbtx"
|
|
"github.com/harness/gitness/types"
|
|
"github.com/harness/gitness/types/enum"
|
|
)
|
|
|
|
// MoveInput is used for moving a repo.
|
|
type MoveInput struct {
|
|
UID *string `json:"uid"`
|
|
ParentID *int64 `json:"parent_id"`
|
|
KeepAsAlias bool `json:"keep_as_alias"`
|
|
}
|
|
|
|
func (i *MoveInput) hasChanges(repo *types.Repository) bool {
|
|
return (i.UID != nil && *i.UID != repo.UID) ||
|
|
(i.ParentID != nil && *i.ParentID != repo.ParentID)
|
|
}
|
|
|
|
// Move moves a repository to a new space and/or uid.
|
|
//
|
|
//nolint:gocognit // refactor if needed
|
|
func (c *Controller) Move(ctx context.Context, session *auth.Session,
|
|
repoRef string, in *MoveInput) (*types.Repository, error) {
|
|
repo, err := c.repoStore.FindByRef(ctx, repoRef)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
permission := enum.PermissionRepoEdit
|
|
if in.ParentID != nil && *in.ParentID != repo.ParentID {
|
|
// ensure user has access to new space (parentId not sanitized!)
|
|
if err = c.checkAuthRepoCreation(ctx, session, *in.ParentID); err != nil {
|
|
return nil, fmt.Errorf("failed to verify repo creation permissions on new parent space: %w", err)
|
|
}
|
|
|
|
// TODO: what would be correct permissions on repo? (technically we are deleting it from the old space)
|
|
permission = enum.PermissionRepoDelete
|
|
}
|
|
if err = apiauth.CheckRepo(ctx, c.authorizer, session, repo, permission, false); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if !in.hasChanges(repo) {
|
|
return repo, nil
|
|
}
|
|
|
|
if err = c.sanitizeMoveInput(in); err != nil {
|
|
return nil, fmt.Errorf("failed to sanitize input: %w", err)
|
|
}
|
|
|
|
err = dbtx.New(c.db).WithTx(ctx, func(ctx context.Context) error {
|
|
repo, err = c.repoStore.UpdateOptLock(ctx, repo, func(r *types.Repository) error {
|
|
if in.UID != nil {
|
|
r.UID = *in.UID
|
|
}
|
|
if in.ParentID != nil {
|
|
r.ParentID = *in.ParentID
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("failed to update repo: %w", err)
|
|
}
|
|
|
|
// lock path to ensure it doesn't get updated while we move the repo
|
|
var primaryPath *types.Path
|
|
primaryPath, err = c.pathStore.FindPrimaryWithLock(ctx, enum.PathTargetTypeRepo, repo.ID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to find primary path: %w", err)
|
|
}
|
|
|
|
var parentPath *types.Path
|
|
parentPath, err = c.pathStore.FindPrimary(ctx, enum.PathTargetTypeSpace, repo.ParentID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to find parent space path: %w", err)
|
|
}
|
|
|
|
oldPathValue := primaryPath.Value
|
|
primaryPath.Value = paths.Concatinate(parentPath.Value, repo.UID)
|
|
repo.Path = primaryPath.Value
|
|
|
|
err = c.pathStore.Update(ctx, primaryPath)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to update primary path: %w", err)
|
|
}
|
|
|
|
if in.KeepAsAlias {
|
|
now := time.Now().UnixMilli()
|
|
err = c.pathStore.Create(ctx, &types.Path{
|
|
Version: 0,
|
|
Value: oldPathValue,
|
|
IsPrimary: false,
|
|
TargetType: enum.PathTargetTypeRepo,
|
|
TargetID: repo.ID,
|
|
CreatedBy: session.Principal.ID,
|
|
Created: now,
|
|
Updated: now,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create alias path: %w", err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
repo.GitURL = c.urlProvider.GenerateRepoCloneURL(repo.Path)
|
|
|
|
return repo, nil
|
|
}
|
|
|
|
func (c *Controller) sanitizeMoveInput(in *MoveInput) error {
|
|
if in.UID != nil {
|
|
if err := c.uidCheck(*in.UID, false); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if in.ParentID != nil {
|
|
if *in.ParentID <= 0 {
|
|
return errRepositoryRequiresParent
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|