mirror of
https://github.com/harness/drone.git
synced 2025-05-05 05:51:56 +08:00

This commit contains the following: - Improve and simplify error handling (remove unnecessary wrappers, make it feel like go) - Add extra validation for path creation and resource moving (path has to be within same top space, no top space alias allowed) - Add access logging for rest api and git api
70 lines
1.8 KiB
Go
70 lines
1.8 KiB
Go
// Copyright 2021 Harness Inc. All rights reserved.
|
|
// Use of this source code is governed by the Polyform Free Trial License
|
|
// that can be found in the LICENSE.md file for this repository.
|
|
|
|
package repo
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/harness/gitness/internal/api/guard"
|
|
"github.com/harness/gitness/internal/api/handler/common"
|
|
"github.com/harness/gitness/internal/api/render"
|
|
"github.com/harness/gitness/internal/api/request"
|
|
"github.com/harness/gitness/internal/store"
|
|
"github.com/harness/gitness/types"
|
|
"github.com/harness/gitness/types/check"
|
|
"github.com/harness/gitness/types/enum"
|
|
"github.com/rs/zerolog/hlog"
|
|
)
|
|
|
|
/*
|
|
* Writes json-encoded path information to the http response body.
|
|
*/
|
|
func HandleCreatePath(guard *guard.Guard, repos store.RepoStore) http.HandlerFunc {
|
|
return guard.Repo(
|
|
enum.PermissionRepoEdit,
|
|
false,
|
|
func(w http.ResponseWriter, r *http.Request) {
|
|
ctx := r.Context()
|
|
log := hlog.FromRequest(r)
|
|
repo, _ := request.RepoFrom(ctx)
|
|
usr, _ := request.UserFrom(ctx)
|
|
|
|
in := new(common.CreatePathRequest)
|
|
err := json.NewDecoder(r.Body).Decode(in)
|
|
if err != nil {
|
|
render.BadRequestf(w, "Invalid request body: %s.", err)
|
|
return
|
|
}
|
|
|
|
params := &types.PathParams{
|
|
Path: strings.ToLower(in.Path),
|
|
CreatedBy: usr.ID,
|
|
Created: time.Now().UnixMilli(),
|
|
Updated: time.Now().UnixMilli(),
|
|
}
|
|
|
|
// validate path
|
|
if err = check.PathParams(params, repo.Path, false); err != nil {
|
|
render.UserfiedErrorOrInternal(w, err)
|
|
return
|
|
}
|
|
|
|
// TODO: ensure user is authorized to create a path pointing to in.Path
|
|
path, err := repos.CreatePath(ctx, repo.ID, params)
|
|
if err != nil {
|
|
log.Error().Err(err).
|
|
Msg("Failed to create path for repo.")
|
|
|
|
render.UserfiedErrorOrInternal(w, err)
|
|
return
|
|
}
|
|
|
|
render.JSON(w, http.StatusOK, path)
|
|
})
|
|
}
|