mirror of
https://github.com/harness/drone.git
synced 2025-05-05 11:50:20 +08:00
3ba0f75c8d
This change adds the following:
- Space UID + Custom harness validation (accountId for top level space, harness identifier for child spaces)
- Repo UID + Custom harness validation (harness identifier)
- Store Unique casing of space / repo path and add Path.ValueUnique (with Unique index) to allow for application layer controlling the case sensitivity (case insensitive standalone vs partially case sensitive harness)
- Token UID (unique index over ownertype + ownerID + tokenUID)
- Add DisplayName for principals (replaces Name to avoid confustion)
- Store Unique casing of principal UID and add Principal.ValueUnique (with unique index) to allow for application layer, per principal type control of case sensitivity (required in embedded mode)
- Generate serviceAccount UID (+Email) Randomly (sa-{space|repo}-{ID}-{random}) - Allows to have a unique UID across all principals while reducing likelyhood of overlaps with users + avoid overlap across spaces / repos.
- Sync casing of space names (accountId orgId projectId) when creating spaces on the fly (to ensure case sensitivity of - harness code) or use the existing space to update casing.
- Update serviceaccount client to match updated NG Manager API
- in embedded mode create spaces for harness resources owning the service account
90 lines
2.6 KiB
Go
90 lines
2.6 KiB
Go
// Copyright 2022 Harness Inc. All rights reserved.
|
|
// Use of this source code is governed by the Polyform Free Trial License
|
|
// that can be found in the LICENSE.md file for this repository.
|
|
|
|
package space
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
apiauth "github.com/harness/gitness/internal/api/auth"
|
|
"github.com/harness/gitness/internal/api/usererror"
|
|
"github.com/harness/gitness/internal/auth"
|
|
"github.com/harness/gitness/internal/paths"
|
|
"github.com/harness/gitness/types"
|
|
"github.com/harness/gitness/types/check"
|
|
"github.com/harness/gitness/types/enum"
|
|
)
|
|
|
|
// MoveInput is used for moving a space.
|
|
type MoveInput struct {
|
|
UID *string `json:"uid"`
|
|
ParentID *int64 `json:"parentId"`
|
|
KeepAsAlias bool `json:"keepAsAlias"`
|
|
}
|
|
|
|
/*
|
|
* Move moves a space to a new space and/or name.
|
|
*/
|
|
func (c *Controller) Move(ctx context.Context, session *auth.Session,
|
|
spaceRef string, in *MoveInput) (*types.Space, error) {
|
|
space, err := findSpaceFromRef(ctx, c.spaceStore, spaceRef)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if err = apiauth.CheckSpace(ctx, c.authorizer, session, space, enum.PermissionSpaceEdit, false); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// backfill data
|
|
if in.UID == nil {
|
|
in.UID = &space.UID
|
|
}
|
|
if in.ParentID == nil {
|
|
in.ParentID = &space.ParentID
|
|
}
|
|
|
|
// verify input
|
|
if err = check.UID(*in.UID); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// ensure it's not a no-op
|
|
if *in.ParentID == space.ParentID && *in.UID == space.UID {
|
|
return nil, usererror.ErrNoChange
|
|
}
|
|
|
|
// Ensure we can create spaces within the target space (using parent space as scope, similar to create)
|
|
// TODO: restrict top level move
|
|
if *in.ParentID > 0 && *in.ParentID != space.ParentID {
|
|
var newParent *types.Space
|
|
newParent, err = c.spaceStore.Find(ctx, *in.ParentID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to get target space of move: %w", err)
|
|
}
|
|
|
|
scope := &types.Scope{SpacePath: newParent.Path}
|
|
resource := &types.Resource{
|
|
Type: enum.ResourceTypeSpace,
|
|
Name: "",
|
|
}
|
|
if err = apiauth.Check(ctx, c.authorizer, session, scope, resource, enum.PermissionSpaceCreate); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
/*
|
|
* Validate path depth (Due to racing conditions we can't be 100% sure on the path here only best
|
|
* effort to avoid big transaction failure)
|
|
* Only needed if we actually change the parent (and can skip top level, as we already validate the name)
|
|
*/
|
|
path := paths.Concatinate(newParent.Path, *in.UID)
|
|
if err = check.PathDepth(path, true); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
return c.spaceStore.Move(ctx, session.Principal.ID, space.ID, *in.ParentID, *in.UID, in.KeepAsAlias)
|
|
}
|