mirror of
https://github.com/harness/drone.git
synced 2025-05-06 05:40:32 +08:00
3ba0f75c8d
This change adds the following:
- Space UID + Custom harness validation (accountId for top level space, harness identifier for child spaces)
- Repo UID + Custom harness validation (harness identifier)
- Store Unique casing of space / repo path and add Path.ValueUnique (with Unique index) to allow for application layer controlling the case sensitivity (case insensitive standalone vs partially case sensitive harness)
- Token UID (unique index over ownertype + ownerID + tokenUID)
- Add DisplayName for principals (replaces Name to avoid confustion)
- Store Unique casing of principal UID and add Principal.ValueUnique (with unique index) to allow for application layer, per principal type control of case sensitivity (required in embedded mode)
- Generate serviceAccount UID (+Email) Randomly (sa-{space|repo}-{ID}-{random}) - Allows to have a unique UID across all principals while reducing likelyhood of overlaps with users + avoid overlap across spaces / repos.
- Sync casing of space names (accountId orgId projectId) when creating spaces on the fly (to ensure case sensitivity of - harness code) or use the existing space to update casing.
- Update serviceaccount client to match updated NG Manager API
- in embedded mode create spaces for harness resources owning the service account
56 lines
1.3 KiB
Go
56 lines
1.3 KiB
Go
// Copyright 2022 Harness Inc. All rights reserved.
|
|
// Use of this source code is governed by the Polyform Free Trial License
|
|
// that can be found in the LICENSE.md file for this repository.
|
|
|
|
package check
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/harness/gitness/types"
|
|
)
|
|
|
|
var (
|
|
illegalRootSpaceNames = []string{"api"}
|
|
|
|
ErrRootSpaceNameNotAllowed = &ValidationError{
|
|
fmt.Sprintf("The following names are not allowed for a root space: %v", illegalRootSpaceNames),
|
|
}
|
|
ErrInvalidParentID = &ValidationError{
|
|
"Parent ID has to be either zero for a root space or greater than zero for a child space.",
|
|
}
|
|
)
|
|
|
|
// Space returns true if the Space is valid.
|
|
type Space func(*types.Space) error
|
|
|
|
// SpaceDefault is the default space validation.
|
|
func SpaceDefault(space *types.Space) error {
|
|
// validate UID
|
|
if err := UID(space.UID); err != nil {
|
|
return err
|
|
}
|
|
|
|
// validate the rest
|
|
return SpaceNoUID(space)
|
|
}
|
|
|
|
// SpaceNoUID validates the space and ignores the UID field.
|
|
func SpaceNoUID(space *types.Space) error {
|
|
if space.ParentID < 0 {
|
|
return ErrInvalidParentID
|
|
}
|
|
|
|
// root space specific validations
|
|
if space.ParentID == 0 {
|
|
for _, p := range illegalRootSpaceNames {
|
|
if strings.HasPrefix(space.UID, p) {
|
|
return ErrRootSpaceNameNotAllowed
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|