drone/internal/api/handler/space/update.go
Johannes Batzill 1115a5083b Add Paths support and error improvements (#11)
This change is adding the concept of Paths.
A repository and space always have a Primary Path which always is represents the ancestry to the root space.
All access history / resource visibility / child listings / UI traversal / etc. is done via that path.

Additionally, repos and spaces can have Alias Paths, which as the name states are aliases. via the primary path.
They sole impact is that a space or repo can be reached via different paths from the UI / rest apis / git apis.
This fulfills two major purposes:
- Customers can rename or move projects and spaces without breaking any existing references from CI pipeliens / code bases / local repos / ...
- Customer can create shorter aliases for important repos when in harness embeded mode! (acc/org/proj/repo can be shortened to acc/repo, or acc/repo'

Apart from the path changes, this PR adds:

Improved User facing errors
Improved internal error handling and wrapping
update / rename operation for repo and space
path list / delete / create operation for repo and space
2022-09-08 21:39:15 -07:00

78 lines
1.9 KiB
Go

// Copyright 2021 Harness Inc. All rights reserved.
// Use of this source code is governed by the Polyform Free Trial License
// that can be found in the LICENSE.md file for this repository.
package space
import (
"encoding/json"
"net/http"
"time"
"github.com/harness/gitness/internal/api/guard"
"github.com/harness/gitness/internal/api/render"
"github.com/harness/gitness/internal/api/request"
"github.com/harness/gitness/internal/store"
"github.com/harness/gitness/types/check"
"github.com/harness/gitness/types/enum"
"github.com/harness/gitness/types/errs"
"github.com/rs/zerolog/log"
)
type spaceUpdateRequest struct {
DisplayName *string `json:"displayName"`
Description *string `json:"description"`
IsPublic *bool `json:"isPublic"`
}
/*
* Updates an existing space.
*/
func HandleUpdate(guard *guard.Guard, spaces store.SpaceStore) http.HandlerFunc {
return guard.Space(
enum.PermissionSpaceEdit,
false,
func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
space, _ := request.SpaceFrom(ctx)
in := new(spaceUpdateRequest)
err := json.NewDecoder(r.Body).Decode(in)
if err != nil {
render.BadRequestf(w, "Invalid request body: %s.", err)
return
}
// update values only if provided
if in.DisplayName != nil {
space.DisplayName = *in.DisplayName
}
if in.Description != nil {
space.Description = *in.Description
}
if in.IsPublic != nil {
space.IsPublic = *in.IsPublic
}
// always update time
space.Updated = time.Now().UnixMilli()
// ensure provided values are valid
if err := check.Space(space); err != nil {
render.BadRequest(w, err)
return
}
err = spaces.Update(ctx, space)
if err != nil {
log.Error().Err(err).
Msg("Space update failed.")
render.InternalError(w, errs.Internal)
return
}
render.JSON(w, space, http.StatusOK)
})
}