drone/internal/api/handler/space/list.go
Johannes Batzill 1115a5083b Add Paths support and error improvements (#11)
This change is adding the concept of Paths.
A repository and space always have a Primary Path which always is represents the ancestry to the root space.
All access history / resource visibility / child listings / UI traversal / etc. is done via that path.

Additionally, repos and spaces can have Alias Paths, which as the name states are aliases. via the primary path.
They sole impact is that a space or repo can be reached via different paths from the UI / rest apis / git apis.
This fulfills two major purposes:
- Customers can rename or move projects and spaces without breaking any existing references from CI pipeliens / code bases / local repos / ...
- Customer can create shorter aliases for important repos when in harness embeded mode! (acc/org/proj/repo can be shortened to acc/repo, or acc/repo'

Apart from the path changes, this PR adds:

Improved User facing errors
Improved internal error handling and wrapping
update / rename operation for repo and space
path list / delete / create operation for repo and space
2022-09-08 21:39:15 -07:00

76 lines
2.0 KiB
Go

// Copyright 2021 Harness Inc. All rights reserved.
// Use of this source code is governed by the Polyform Free Trial License
// that can be found in the LICENSE.md file for this repository.
package space
import (
"net/http"
"github.com/harness/gitness/internal/api/guard"
"github.com/harness/gitness/internal/api/render"
"github.com/harness/gitness/internal/api/request"
"github.com/harness/gitness/internal/store"
"github.com/harness/gitness/types"
"github.com/harness/gitness/types/enum"
"github.com/harness/gitness/types/errs"
"github.com/rs/zerolog/hlog"
)
/*
* Writes json-encoded list of child spaces in the request body.
*/
func HandleList(guard *guard.Guard, spaces store.SpaceStore) http.HandlerFunc {
return guard.Space(
enum.PermissionSpaceView,
true,
func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
log := hlog.FromRequest(r)
space, _ := request.SpaceFrom(ctx)
params := request.ParseSpaceFilter(r)
if params.Order == enum.OrderDefault {
params.Order = enum.OrderAsc
}
count, err := spaces.Count(ctx, space.ID)
if err != nil {
log.Err(err).Msgf("Failed to count child spaces.")
render.InternalError(w, errs.Internal)
return
}
allSpaces, err := spaces.List(ctx, space.ID, params)
if err != nil {
log.Err(err).Msgf("Failed to list child spaces.")
render.InternalError(w, errs.Internal)
return
}
/*
* Only list spaces that are either public or can be accessed by the user
*
* TODO: optimize by making a single auth check for all spaces at once.
*/
result := make([]*types.Space, 0, len(allSpaces))
for _, cs := range allSpaces {
if !cs.IsPublic {
err := guard.CheckSpace(r, enum.PermissionSpaceView, cs.Path)
if err != nil {
log.Debug().Err(err).
Msgf("Skip space '%s' in output.", cs.Path)
continue
}
}
result = append(result, cs)
}
render.Pagination(r, w, params.Page, params.Size, int(count))
render.JSON(w, result, 200)
})
}