drone/internal/api/handler/space/create.go
Johannes Batzill 1115a5083b Add Paths support and error improvements (#11)
This change is adding the concept of Paths.
A repository and space always have a Primary Path which always is represents the ancestry to the root space.
All access history / resource visibility / child listings / UI traversal / etc. is done via that path.

Additionally, repos and spaces can have Alias Paths, which as the name states are aliases. via the primary path.
They sole impact is that a space or repo can be reached via different paths from the UI / rest apis / git apis.
This fulfills two major purposes:
- Customers can rename or move projects and spaces without breaking any existing references from CI pipeliens / code bases / local repos / ...
- Customer can create shorter aliases for important repos when in harness embeded mode! (acc/org/proj/repo can be shortened to acc/repo, or acc/repo'

Apart from the path changes, this PR adds:

Improved User facing errors
Improved internal error handling and wrapping
update / rename operation for repo and space
path list / delete / create operation for repo and space
2022-09-08 21:39:15 -07:00

134 lines
3.5 KiB
Go

// Copyright 2021 Harness Inc. All rights reserved.
// Use of this source code is governed by the Polyform Free Trial License
// that can be found in the LICENSE.md file for this repository.
package space
import (
"encoding/json"
"errors"
"net/http"
"strings"
"time"
"github.com/harness/gitness/internal/api/guard"
"github.com/harness/gitness/internal/api/render"
"github.com/harness/gitness/internal/api/request"
"github.com/harness/gitness/internal/paths"
"github.com/harness/gitness/internal/store"
"github.com/harness/gitness/types"
"github.com/harness/gitness/types/check"
"github.com/harness/gitness/types/enum"
"github.com/harness/gitness/types/errs"
"github.com/rs/zerolog/hlog"
)
type spaceCreateRequest struct {
Name string `json:"name"`
ParentId int64 `json:"parentId"`
DisplayName string `json:"displayName"`
Description string `json:"description"`
IsPublic bool `json:"isPublic"`
}
/*
* HandleCreate returns an http.HandlerFunc that creates a new space.
*/
func HandleCreate(guard *guard.Guard, spaces store.SpaceStore) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
log := hlog.FromRequest(r)
in := new(spaceCreateRequest)
err := json.NewDecoder(r.Body).Decode(in)
if err != nil {
render.BadRequestf(w, "Invalid request body: %s.", err)
return
}
// get current user (will be enforced to not be nil via explicit check or guard.Enforce)
usr, _ := request.UserFrom(ctx)
// Collect parent path along the way - needed for duplicate error message
parentPath := ""
/*
* AUTHORIZATION
* Can only be done once we know the parent space
*/
if in.ParentId <= 0 {
// TODO: Restrict top level space creation.
if usr == nil {
render.Unauthorized(w, errs.NotAuthenticated)
return
}
} else {
// Create is a special case - we need the parent path
parent, err := spaces.Find(ctx, in.ParentId)
if errors.Is(err, errs.ResourceNotFound) {
render.NotFoundf(w, "Provided parent space wasn't found.")
return
} else if err != nil {
log.Err(err).Msgf("Failed to get space with id '%s'.", in.ParentId)
render.InternalError(w, errs.Internal)
return
}
scope := &types.Scope{SpacePath: parent.Path}
resource := &types.Resource{
Type: enum.ResourceTypeSpace,
Name: "",
}
if !guard.Enforce(w, r, scope, resource, enum.PermissionSpaceCreate) {
return
}
parentPath = parent.Path
}
// create new space object
space := &types.Space{
Name: strings.ToLower(in.Name),
ParentId: in.ParentId,
DisplayName: in.DisplayName,
Description: in.Description,
IsPublic: in.IsPublic,
CreatedBy: usr.ID,
Created: time.Now().UnixMilli(),
Updated: time.Now().UnixMilli(),
}
// validate space
if err := check.Space(space); err != nil {
render.BadRequest(w, err)
return
}
// validate path (Due to racing conditions we can't be 100% sure on the path here, but that's okay)
path := paths.Concatinate(parentPath, space.Name)
if err = check.PathParams(path, true); err != nil {
render.BadRequest(w, err)
return
}
// create in store
err = spaces.Create(ctx, space)
if errors.Is(err, errs.Duplicate) {
log.Warn().Err(err).
Msg("Space creation failed as a duplicate was detected.")
render.BadRequestf(w, "Path '%s' already exists.", path)
return
} else if err != nil {
log.Error().Err(err).
Msg("Space creation failed.")
render.InternalError(w, errs.Internal)
return
}
render.JSON(w, space, 200)
}
}