Commit Graph

60 Commits

Author SHA1 Message Date
Tan Nhu
09e3c89657 Add empty state for Compare and PR views (#225) 2023-01-17 17:12:53 -08:00
Tan Nhu
eed7b2c29b Consolidate logic to show No Result (#223)
* Add no result search view into repo listing view

* Consolidate logic to show No Result
2023-01-17 16:11:39 -08:00
Tan Nhu
1aa1123bd2 Consolidate pagination for the whole codebase + Use SearchInputWithSpinner component (#222)
* Remove center layout for empty repo info - hard to read

* Consolidate pagination for the whole codebase

* Use SearchInputWithSpinner component

* Use SearchInputWithSpinner component
2023-01-17 14:59:56 -08:00
Tan Nhu
92c82f5c44 Disable branch creation when committing first new file into an empty repo (#217) 2023-01-16 12:20:09 -08:00
Tan Nhu
797e339e02 Implement flow to create a new file when repo is empty (#216)
* Implement flow to create a new file when repo is empty

* Implement flow to create a new file when repo is empty

* Fix edit file does not show content
2023-01-16 11:51:00 -08:00
Tan Nhu
bbae67299c Finish API integration for PR review box (#212) 2023-01-13 13:41:07 -08:00
Tan Nhu
3b5542a61d Add Pagination for Diff view (#208) 2023-01-13 09:23:10 -08:00
Johannes Batzill
65c59d0b5b [MISC] Fix review bugs, regenerate swagger from latest service, fix webhook.has_secret in swagger (#198)
This change contains the following changes:
- allow submitting reviews without comment for approve
- fix openapi for /reviews api and fix UI calls for submitting reviews
- fix recently broken openapi for webhook (it removed has_secret field as part of openapi refactor)
- fix fatal submit review bug (we passed repo.UID not repo.GitUID to gitrpc - not sure how that ever worked?)
- add missing merge pr activity to list of all pr activity enum values
- return all PR states by default
- show Open PRs by default (instead of all) and fix state filtering query
- regenerate code services based on latest swagger
- fix UI code to work with regenerated code service
2023-01-12 22:39:38 -08:00
Tan Nhu
b7e0f6cce5 Minor change to disable Review changes button (#197)
* Minor change to disable Review changes button

* Update PR listing icons
2023-01-12 21:04:08 -08:00
Tan Nhu
73bc9a55f7 Implement PR review changes flow (#195) 2023-01-12 12:45:31 -08:00
Tan Nhu
38fb97b8e2 Add placeholder for Review changes (#193) 2023-01-12 09:56:01 -08:00
Tan Nhu
1c5a588a83 Hide Review button when PR is merged + Fix PR.id issue (#191)
* Replace all references of PR.id by PR.number

* Hide Review button when PR is merged
2023-01-12 04:20:27 -08:00
Tan Nhu
abd132fdf6 Implement Webhook CRUD (#177) 2023-01-11 08:44:50 -08:00
Tan Nhu
4938718aca Add Changes integration into PR Compare view (#164) 2023-01-06 01:56:37 -08:00
Tan Nhu
4c6c2b3b56 Fix service generation bug + fix reply to comment thread rendering (#162) 2023-01-05 23:08:39 -08:00
Tan Nhu
b2c4de4751 Full API integration for PR Conversation tab (#161) 2023-01-05 21:26:50 -08:00
Tan Nhu
8ac12ee341 API integration for Conversation comments (#153) 2023-01-02 16:14:51 -08:00
Tan Nhu
58a2d90973 Redirect to Compare when editing a file with new branch created (#149) 2022-12-29 22:41:43 -08:00
Marko Gaćeša
a79e187a88 DB & API refactor: Use snake case (#144)
Update DB and API to follow Harness Standard
2022-12-29 13:53:08 -08:00
Tan Nhu
e4ae2b269b Implement components to support PR commenting (#146) 2022-12-28 15:58:02 -08:00
Tan Nhu
23792ab2f5 Add Diff view Line Break configuration (#135)
* Add Diff view Line Break configuration

* Minor string change
2022-12-23 00:57:56 -08:00
Johannes Batzill
63c3740e58 [UI] Consume Latest OpenAPI Specs (#134)
* regenerate CODE service code to match latest API specs

* update readme
2022-12-22 21:58:38 -08:00
Tan Nhu
9da9aa42b5 Remove bad tick from icons package (#133) 2022-12-22 15:48:00 -08:00
Tan Nhu
97e70cd581 Implement commenting thread (#132)
* Implement commenting thread

* Add extra comment example
2022-12-22 15:06:56 -08:00
Tan Nhu
da3bfc9bd0 Implement PR commenting prototype (#131)
* Remove unused packages

* Remove some unused packages

* Height adjustment calculation for DiffViewer with CommentBox inside

* Add logic to render existing comments

* Improve rendering performance

* Remove optimization that makes things slow

* Use 'auto' to boost re-layout performance

* Fix wrong height calculation when 'auto' is being sent

* Fix CommentBox height adjustment when comments got changed
2022-12-22 13:34:54 -08:00
Tan Nhu
43c7e94e06 Add markdown editor into commenting (#128)
* Small refactoring

* Refactoring: Make it a bit easier for DOM manipulation

* Add markdown editor into commenting
2022-12-20 11:28:56 -08:00
Tan Nhu
0d49ef1d69 Prototyping for diff annotations (#127) 2022-12-16 09:57:52 -08:00
Tan Nhu
619fd2c9de Add PR listing page + Commits tab for PR detail page (#123)
* Add PR listing page + Commits tab for PR detail page

* Add commits place-holder in Compare view

* Add commits place-holder in Compare view

* Correct PR number after creation

* Minor CSS improvement

* Add diff sample

* Diff side by side (3.4.2 is better than latest)

* Big PR diff example

* Implement diff view

* Scrolling optimization

* Add placeholder to allow click at line number
2022-12-12 16:39:14 -08:00
Tan Nhu
225199b008 feat: Add Create Git Pull Request flow (#111) 2022-12-02 21:32:42 -08:00
Tan Nhu
edb6baabc6 Refactor to use shorter names + initial code for PR (#104) 2022-12-01 11:21:25 -08:00
Tan Nhu
6e5147578b Minor padding improvements (#102) 2022-11-29 20:01:13 -08:00
Tan Nhu
a90fc1c59e Fix 500 exception when editing a file (#96) 2022-11-29 02:48:37 -08:00
Tan Nhu
505d72049b Finalize API integration for commits (#95) 2022-11-29 02:21:23 -08:00
Tan Nhu
17c93350ae feat: [SCM-36]: Refactor SCM to CODE (#92) 2022-11-23 16:39:41 -08:00
Tan Nhu
68de8e236b Fix branches pagination (#88) 2022-11-23 02:53:51 -08:00
Tan Nhu
cc6fbbf58d Resolve cicular dependency (#87) 2022-11-22 14:12:16 -08:00
Tan Nhu
362137440f Use new BranchTagSelect in creating a new branch modal (#84)
* Use new BranchTagSelect in creating a new branch modal

* Use new BranchTagSelect in creating a new branch modal
2022-11-22 03:16:24 -08:00
Tan Nhu
49736b308c Add BranchTagSelect component (#83)
* Fix message encoding

* Add prototype for BranchTagSelect component

* Finish BranchAndTag component
2022-11-22 02:35:18 -08:00
Tan Nhu
6d8c979e7c Implement Branch item actions (#79)
* Implement Branch item actions

* Implement Branch item actions
2022-11-17 01:48:48 -08:00
Tan Nhu
7116c2fbe4 Implement Create Branch (#78)
* Update new icons

* Implement Create Branch
2022-11-17 00:16:57 -08:00
Tan Nhu
f204a5a2f8 Fix double ? in API URL (#75) 2022-11-15 13:21:31 -08:00
Tan Nhu
782c6f2bd7 Refactor type system + add flow to copy/edit/delete a file (#73)
* Fix double query

* Add file toolbar buttons + wire up copy, delete, etc...

* Refactor type system
2022-11-15 02:42:59 -08:00
Tan Nhu
31a58e3172 Add routingId to support Harness gateway + Prototype for Commit modal (#68)
* Implement file path edit input

* Implement file path edit input - cont

* Prototype for Commit modal

* Add routingId to support Harness gateway
2022-11-10 15:17:55 -08:00
Tan Nhu
93dbc6005f Correct API URL path + minor code editor change (#61)
* autoFocus editor

* Correct API URL path
2022-11-08 16:37:13 -08:00
Tan Nhu
073154eebb Update clone URL + minor code refactoring (#60)
* FileEditor improvements

* Update clone URL + minor code refactoring
2022-11-08 14:34:43 -08:00
Johannes Batzill
8fe80ab811 Remove Identifier from UI - Replace with original Name (#59)
* remove identifier from UI and replace it with original 'Name'
* extend uid to length 100
* allow repo name of length 1
2022-11-07 14:37:50 -08:00
Tan Nhu
c7f852cbf4 Flow for edit file (#58) 2022-11-07 11:35:48 -08:00
Johannes Batzill
3ba0f75c8d Introduce UIDs for Space / Repo / Tokens, Add Custom Harness Validation, ... (#57)
This change adds the following:
- Space UID + Custom harness validation (accountId for top level space, harness identifier for child spaces)
- Repo UID + Custom harness validation (harness identifier)
- Store Unique casing of space / repo path and add Path.ValueUnique (with Unique index) to allow for application layer controlling the case sensitivity (case insensitive standalone vs partially case sensitive harness)
- Token UID (unique index over ownertype + ownerID + tokenUID)
- Add DisplayName for principals (replaces Name to avoid confustion)
- Store Unique casing of principal UID and add Principal.ValueUnique (with unique index) to allow for application layer, per principal type control of case sensitivity (required in embedded mode)
- Generate serviceAccount UID (+Email) Randomly (sa-{space|repo}-{ID}-{random}) - Allows to have a unique UID across all principals while reducing likelyhood of overlaps with users + avoid overlap across spaces / repos.
- Sync casing of space names (accountId orgId projectId) when creating spaces on the fly (to ensure case sensitivity of - harness code) or use the existing space to update casing.
- Update serviceaccount client to match updated NG Manager API
- in embedded mode create spaces for harness resources owning the service account
2022-11-06 23:14:47 -08:00
Tan Nhu
2fe8669119 Add clone tooltip (#56) 2022-11-06 12:39:14 -08:00
Tan Nhu
0d5771d706 Implement Branches page (#55) 2022-11-04 00:22:21 -07:00