github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-08 13:20:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: [code-286]: fix tag comments

Browse Source
This commit is contained in:
calvin 2023-05-30 13:19:14 -06:00
parent a71fba525f
commit fe7f59eb10
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
web/src/components/CreateTagModal/CreateTagModal.tsx
View File

@ -147,7 +147,6 @@ export function useCreateTagModal({
repoMetadata={repoMetadata}
disableBranchCreation
disableViewAllBranches
forBranchesOnly
gitRef={sourceBranch}
onSelect={setSourceBranch}
/>

2
web/src/pages/RepositoryTags/RepositoryTagsContentHeader/RepositoryTagsContentHeader.tsx
View File

@ -22,12 +22,12 @@ export function RepositoryTagsContentHeader({
}: RepositoryTagsContentHeaderProps) {
const { getString } = useStrings()
const [searchTerm, setSearchTerm] = useState('')
return (
<Container className={css.main}>
<Layout.Horizontal spacing="medium">
<SearchInputWithSpinner
spinnerPosition="right"
loading={loading}
query={searchTerm}
setQuery={value => {

15
web/src/pages/RepositoryTags/TagsContent/TagsContent.tsx
View File

@ -21,6 +21,7 @@ import type {
OpenapiCalculateCommitDivergenceRequest,
RepoBranch,
RepoCommitDivergence,
RepoCommitTag,
TypesRepository
} from 'services/code'
import { formatDate, getErrorMessage, voidFn } from 'utils/Utils'
@ -28,7 +29,7 @@ import { useConfirmAction } from 'hooks/useConfirmAction'
import { OptionsMenuButton } from 'components/OptionsMenuButton/OptionsMenuButton'
import { useCreateBranchModal } from 'components/CreateBranchModal/CreateBranchModal'
import { CommitActions } from 'components/CommitActions/CommitActions'
import { CodeIcon } from 'utils/GitUtils'
import { CodeIcon, REFS_TAGS_PREFIX } from 'utils/GitUtils'
import css from './TagsContent.module.scss'
interface TagsContentProps {
@ -63,7 +64,7 @@ export function TagsContent({ repoMetadata, searchTerm = '', branches, onDeleteS
}
}, [getBranchDivergence, branchDivergenceRequestBody])
const onSuccess = voidFn(noop)
const openModal = useCreateBranchModal({ repoMetadata, onSuccess })
const openModal = useCreateBranchModal({ repoMetadata, onSuccess,showSuccessMessage: true })
const columns: Column<RepoBranch>[] = useMemo(
() => [
@ -110,12 +111,12 @@ export function TagsContent({ repoMetadata, searchTerm = '', branches, onDeleteS
{
Header: getString('tagger'),
width: '20%',
Cell: ({ row }: CellProps<RepoBranch>) => {
Cell: ({ row }: CellProps<RepoCommitTag>) => {
return (
<Text className={css.rowText} color={Color.BLACK} tag="div">
<Avatar hoverCard={false} size="small" name={row.original.commit?.author?.identity?.name || ''} />
<span className={css.spacer} />
{row.original.commit?.author?.identity?.name || ''}
{row.original.tagger?.identity?.name || ''}
</Text>
)
}
@ -123,11 +124,11 @@ export function TagsContent({ repoMetadata, searchTerm = '', branches, onDeleteS
{
Header: getString('creationDate'),
width: '200px',
Cell: ({ row }: CellProps<RepoBranch>) => {
Cell: ({ row }: CellProps<RepoCommitTag>) => {
return (
<Text className={css.rowText} color={Color.BLACK} tag="div">
<span className={css.spacer} />
{formatDate(row.original.commit?.author?.when as string)}
{formatDate(row.original.tagger?.when as string)}
</Text>
)
}
@ -179,7 +180,7 @@ export function TagsContent({ repoMetadata, searchTerm = '', branches, onDeleteS
history.push(
routes.toCODERepository({
repoPath: repoMetadata.path as string,
gitRef: row.original?.name
gitRef: `${REFS_TAGS_PREFIX}${row.original?.name}`
})
)
}