github/drone
5
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-04 15:01:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: [CDE-364]: Adding checks and logging for active time calculation during instance update. (#2767)

Browse Source 
* feat: [CDE-364]: Adding checks and logging for active time calculation during instance update.
This commit is contained in:
Dhruv Dhruv 2024-10-03 08:53:53 +00:00 committed by Harness
parent 0e8dc4e544
commit fcc4f4b142
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
app/store/database/gitspace_instance.go
View File

@ -30,6 +30,7 @@ import (
"github.com/guregu/null" "github.com/guregu/null"
"github.com/jmoiron/sqlx" "github.com/jmoiron/sqlx"
"github.com/pkg/errors" "github.com/pkg/errors"
"github.com/rs/zerolog/log"
) )
var _ store.GitspaceInstanceStore = (*gitspaceInstanceStore)(nil) var _ store.GitspaceInstanceStore = (*gitspaceInstanceStore)(nil)
@ -230,6 +231,7 @@ func (g gitspaceInstanceStore) Update(
ctx context.Context, ctx context.Context,
gitspaceInstance *types.GitspaceInstance, gitspaceInstance *types.GitspaceInstance,
) error { ) error {
validateActiveTimeDetails(gitspaceInstance)
stmt := database.Builder. stmt := database.Builder.
Update(gitspaceInstanceTable). Update(gitspaceInstanceTable).
Set("gits_state", gitspaceInstance.State). Set("gits_state", gitspaceInstance.State).
@ -396,3 +398,36 @@ func (g gitspaceInstanceStore) mapToGitspaceInstances(
} }
return res, nil return res, nil
} }
func validateActiveTimeDetails(gitspaceInstance *types.GitspaceInstance) {
if (gitspaceInstance.State == enum.GitspaceInstanceStateStarting ||
gitspaceInstance.State == enum.GitspaceInstanceStateUninitialized) &&
(gitspaceInstance.ActiveTimeStarted != nil ||
gitspaceInstance.ActiveTimeEnded != nil ||
gitspaceInstance.TotalTimeUsed != 0) {
log.Warn().Msgf("instance has incorrect active time, details: identifier %s state %s active time start "+
"%d active time end %d total time used %d", gitspaceInstance.Identifier, gitspaceInstance.State,
gitspaceInstance.ActiveTimeStarted, gitspaceInstance.ActiveTimeEnded, gitspaceInstance.TotalTimeUsed)
}
if (gitspaceInstance.State == enum.GitspaceInstanceStateRunning) &&
(gitspaceInstance.ActiveTimeStarted == nil ||
gitspaceInstance.ActiveTimeEnded != nil ||
gitspaceInstance.TotalTimeUsed != 0) {
log.Warn().Msgf(
"instance is missing active time start or has incorrect end/total timestamps, details: "+
" identifier %s state %s active time start %d active time end %d total time used %d",
gitspaceInstance.Identifier, gitspaceInstance.State, gitspaceInstance.ActiveTimeStarted,
gitspaceInstance.ActiveTimeEnded, gitspaceInstance.TotalTimeUsed)
}
if (gitspaceInstance.State == enum.GitspaceInstanceStateDeleted ||
gitspaceInstance.State == enum.GitspaceInstanceStateStopping ||
gitspaceInstance.State == enum.GitspaceInstanceStateError) &&
(gitspaceInstance.ActiveTimeStarted == nil ||
gitspaceInstance.ActiveTimeEnded == nil ||
gitspaceInstance.TotalTimeUsed == 0) {
log.Warn().Msgf("instance is missing active time start/end/total timestamp, details: "+
" identifier %s state %s active time start %d active time end %d total time used %d",
gitspaceInstance.Identifier, gitspaceInstance.State, gitspaceInstance.ActiveTimeStarted,
gitspaceInstance.ActiveTimeEnded, gitspaceInstance.TotalTimeUsed)
}
}