From edf01c5a9bfe94e12c944be11827c11f449e64d6 Mon Sep 17 00:00:00 2001 From: Shivakumar Ningappa Date: Tue, 12 Nov 2024 13:18:42 +0000 Subject: [PATCH] fix: [AH-585]: add index to improve query performance found during load testing (#2982) * fix: [AH-585]: add index to improve query performance found during load testing --- app/store/database/migrate/postgres/0086_create_idx_gc.down.sql | 1 + app/store/database/migrate/postgres/0086_create_idx_gc.up.sql | 2 ++ app/store/database/migrate/sqlite/0086_create_idx_gc.down.sql | 2 ++ app/store/database/migrate/sqlite/0086_create_idx_gc.up.sql | 2 ++ registry/app/pkg/docker/local.go | 2 +- 5 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 app/store/database/migrate/postgres/0086_create_idx_gc.down.sql create mode 100644 app/store/database/migrate/postgres/0086_create_idx_gc.up.sql create mode 100644 app/store/database/migrate/sqlite/0086_create_idx_gc.down.sql create mode 100644 app/store/database/migrate/sqlite/0086_create_idx_gc.up.sql diff --git a/app/store/database/migrate/postgres/0086_create_idx_gc.down.sql b/app/store/database/migrate/postgres/0086_create_idx_gc.down.sql new file mode 100644 index 000000000..dfce189b6 --- /dev/null +++ b/app/store/database/migrate/postgres/0086_create_idx_gc.down.sql @@ -0,0 +1 @@ +DROP INDEX IF EXISTS index_gc_manifest_review_queue2; diff --git a/app/store/database/migrate/postgres/0086_create_idx_gc.up.sql b/app/store/database/migrate/postgres/0086_create_idx_gc.up.sql new file mode 100644 index 000000000..874c11bcd --- /dev/null +++ b/app/store/database/migrate/postgres/0086_create_idx_gc.up.sql @@ -0,0 +1,2 @@ +CREATE INDEX IF NOT EXISTS index_gc_manifest_review_queue2 +ON gc_manifest_review_queue (registry_id, manifest_id, review_after); diff --git a/app/store/database/migrate/sqlite/0086_create_idx_gc.down.sql b/app/store/database/migrate/sqlite/0086_create_idx_gc.down.sql new file mode 100644 index 000000000..5315ab411 --- /dev/null +++ b/app/store/database/migrate/sqlite/0086_create_idx_gc.down.sql @@ -0,0 +1,2 @@ +--noop as gc_manifest_review_queue table doesn't exist in gitness +; diff --git a/app/store/database/migrate/sqlite/0086_create_idx_gc.up.sql b/app/store/database/migrate/sqlite/0086_create_idx_gc.up.sql new file mode 100644 index 000000000..5315ab411 --- /dev/null +++ b/app/store/database/migrate/sqlite/0086_create_idx_gc.up.sql @@ -0,0 +1,2 @@ +--noop as gc_manifest_review_queue table doesn't exist in gitness +; diff --git a/registry/app/pkg/docker/local.go b/registry/app/pkg/docker/local.go index 770b6982f..11a1fe11f 100644 --- a/registry/app/pkg/docker/local.go +++ b/registry/app/pkg/docker/local.go @@ -78,7 +78,7 @@ const ( const ( manifestListCreateGCReviewWindow = 1 * time.Hour manifestListCreateGCLockTimeout = 10 * time.Second - manifestTagGCLockTimeout = 10 * time.Second + manifestTagGCLockTimeout = 30 * time.Second tagDeleteGCLockTimeout = 10 * time.Second manifestTagGCReviewWindow = 1 * time.Hour manifestDeleteGCReviewWindow = 1 * time.Hour